From: Dodji Seketeli <dodji@seketeli.org>
To: "simark at simark dot ca" <sourceware-bugzilla@sourceware.org>
Cc: libabigail@sourceware.org
Subject: Re: [Bug default/25058] abigail does not handle subprogram DIEs with DW_AT_ranges instead of DW_AT_low_pc
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <877e5krigh.fsf@seketeli.org> (raw)
In-Reply-To: <bug-25058-9487-Nr2vPLAAFw@http.sourceware.org/bugzilla/> (simark at simark dot ca's message of "Thu, 03 Oct 2019 14:31:51 +0000")
"simark at simark dot ca" <sourceware-bugzilla@sourceware.org> a écrit:
> Just to clarify: by looking up the ELF symbol associated to the low pc of the
> _first_ range may not be sufficient, as it could give you the wrong ELF symbol.
[...]
Right, I think we should get the first address that corresponds to a
function symbol that is defined and publicly exported.
I initially wrote a patch that was just taking the first address of the
range referred to by DW_AT_ranges, and then I read your comment
addressing this issue and I updated the patch to make sure the address
we are getting (from the range) is for a publicly exported function
symbol.
Thanks for the discussion.
--
Dodji
next prev parent reply other threads:[~2019-10-04 9:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 [Bug default/25058] New: abigail does not recognize simark at simark dot ca
2019-01-01 0:00 ` [Bug default/25058] abigail does not handle subprogram DIEs with DW_AT_ranges instead of DW_AT_low_pc simark at simark dot ca
2019-01-01 0:00 ` Dodji Seketeli
2019-01-01 0:00 ` simark at simark dot ca
2019-01-01 0:00 ` simark at simark dot ca
2019-01-01 0:00 ` Dodji Seketeli [this message]
2019-01-01 0:00 ` simark at simark dot ca
2019-01-01 0:00 ` dodji at seketeli dot org
2019-01-01 0:00 ` mark at klomp dot org
2019-01-01 0:00 ` simark at simark dot ca
2019-01-01 0:00 ` dodji at seketeli dot org
2019-01-01 0:00 ` simark at simark dot ca
2019-01-01 0:00 ` mark at klomp dot org
2019-01-01 0:00 ` simark at simark dot ca
2019-01-01 0:00 ` dodji at redhat dot com
2019-01-01 0:00 ` dodji at redhat dot com
2019-01-01 0:00 ` simark at simark dot ca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e5krigh.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=libabigail@sourceware.org \
--cc=sourceware-bugzilla@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).