From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5723 invoked by alias); 4 Oct 2019 09:03:17 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Id: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 5415 invoked by uid 89); 4 Oct 2019 09:03:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:797 X-Spam-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay3-d.mail.gandi.net Received: from relay3-d.mail.gandi.net (HELO relay3-d.mail.gandi.net) (217.70.183.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 Oct 2019 09:03:15 +0000 X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 7C4BF6000E; Fri, 4 Oct 2019 09:03:12 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id EFBD3180006A; Fri, 4 Oct 2019 11:03:10 +0200 (CEST) From: Dodji Seketeli To: "simark at simark dot ca" Cc: libabigail@sourceware.org Subject: Re: [Bug default/25058] abigail does not handle subprogram DIEs with DW_AT_ranges instead of DW_AT_low_pc Organization: Me, myself and I References: X-Operating-System: Red Hat Enterprise Linux Workstation 7.7 X-URL: http://www.seketeli.net/~dodji Date: Tue, 01 Jan 2019 00:00:00 -0000 In-Reply-To: (simark at simark dot ca's message of "Thu, 03 Oct 2019 14:31:51 +0000") Message-ID: <877e5krigh.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00021.txt.bz2 "simark at simark dot ca" a =C3=A9crit: > Just to clarify: by looking up the ELF symbol associated to the low pc of= the > _first_ range may not be sufficient, as it could give you the wrong ELF s= ymbol. [...] Right, I think we should get the first address that corresponds to a function symbol that is defined and publicly exported. I initially wrote a patch that was just taking the first address of the range referred to by DW_AT_ranges, and then I read your comment addressing this issue and I updated the patch to make sure the address we are getting (from the range) is for a publicly exported function symbol. Thanks for the discussion. --=20 Dodji