public inbox for
 help / color / mirror / Atom feed
From: Dodji Seketeli <>
To: Giuliano Procida <>
Subject: Re: [PATCH 3/3] abidw: resolve declaration-only enums the same as classes
Date: Mon, 29 Aug 2022 13:20:19 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Giuliano Procida's message of "Thu, 25 Aug 2022 12:48:56 +0100")

Giuliano Procida <> a écrit:

> The logic for resolving declaration-only enums and classes was almost
> the same. However, the class code had a couple of extra improvements
> that were missing from the enum code. One of these caused resolution
> failures with Linux kernel ABIs, resulting in duplicate (declared /
> defined) enums in ABI XML.
> This change adds the improvements to the enum resolution code.
> 	* src/
> 	(read_context::resolve_declaration_only_enums): Use an ordered
> 	map to ensure TUs are always considered in the same order and
> 	so improve ABI XML stability. Given multiple possible
> 	definitions for a enum declaration, check to see if they are
> 	equal and resolve the declaration to the first definition if
> 	so.
> Signed-off-by: Giuliano Procida <>

Applied to master, thanks!




      reply	other threads:[~2022-08-29 11:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25 11:48 [PATCH 0/3] Improve resolution of declaration-only enums Giuliano Procida
2022-08-25 11:48 ` [PATCH 1/3] abidw: fix --stats output for resolved classes and enums Giuliano Procida
2022-08-29 11:19   ` Dodji Seketeli
2022-08-25 11:48 ` [PATCH 2/3] abidw: remove always true test in resolve_declaration_only_classes Giuliano Procida
2022-08-29 11:19   ` Dodji Seketeli
2022-08-25 11:48 ` [PATCH 3/3] abidw: resolve declaration-only enums the same as classes Giuliano Procida
2022-08-29 11:20   ` Dodji Seketeli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).