From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by sourceware.org (Postfix) with ESMTPS id CCF7D3858C50 for ; Mon, 29 Aug 2022 11:20:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CCF7D3858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id EA53A60004; Mon, 29 Aug 2022 11:20:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1661772020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xa2+DcS7HYo+q2Z/3XfwOGZp8AclpbDEKPLalO5CiD0=; b=o+NLyAgIL+86h6W82A3iZmNKP5bhqaJp+7+7mJlBBSyqZYlZJMc02FkT73dMMV0hMGf8uz pnN0tTdNsxH61/nrbnqQGOOA8Y/+vlgmH8D+8lHgZ4SbYrbA0CMHUgS3GiiiB7nu5P7u01 qpeLjnRsNofS2yEDOykpAQMvyZb/epEscVhhzXQSf/QRHhANS8kfpaI5jNVDu6mGyIgv4y iC46X7cc4MTke0nvsK3PqcU0fI7mGY+A/+z1rwk+XygsORraYXKrzG5Tw/0WrOSIW2NKg+ WggzjZK0JnN3Z5aKqxZYAFReyLn7t22T5FizYYdMs/pCGW/lcG1cyqBRl5YIjA== Received: by localhost (Postfix, from userid 1000) id 5D62A5802BD; Mon, 29 Aug 2022 13:20:19 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com, sidnayyar@google.com, vvvvvv@google.com Subject: Re: [PATCH 3/3] abidw: resolve declaration-only enums the same as classes Organization: Me, myself and I References: <20220825114856.3137373-1-gprocida@google.com> <20220825114856.3137373-4-gprocida@google.com> X-Operating-System: Fedora 38 X-URL: http://www.seketeli.net/~dodji Date: Mon, 29 Aug 2022 13:20:19 +0200 In-Reply-To: <20220825114856.3137373-4-gprocida@google.com> (Giuliano Procida's message of "Thu, 25 Aug 2022 12:48:56 +0100") Message-ID: <878rn7l2j0.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Giuliano Procida a =C3=A9crit: > The logic for resolving declaration-only enums and classes was almost > the same. However, the class code had a couple of extra improvements > that were missing from the enum code. One of these caused resolution > failures with Linux kernel ABIs, resulting in duplicate (declared / > defined) enums in ABI XML. > > This change adds the improvements to the enum resolution code. > > * src/abg-dwarf-reader.cc > (read_context::resolve_declaration_only_enums): Use an ordered > map to ensure TUs are always considered in the same order and > so improve ABI XML stability. Given multiple possible > definitions for a enum declaration, check to see if they are > equal and resolve the declaration to the first definition if > so. > > Signed-off-by: Giuliano Procida Applied to master, thanks! [...] Cheers, --=20 Dodji