From: Dodji Seketeli <dodji@seketeli.org>
To: Matthias Maennich <maennich@google.com>
Cc: libabigail@sourceware.org, gprocida@google.com,
kernel-team@android.com
Subject: Re: [PATCH 1/2] elf-helpers: refactor find_symbol_table_section
Date: Thu, 15 Jul 2021 16:18:30 +0200 [thread overview]
Message-ID: <878s27fyo9.fsf@seketeli.org> (raw)
In-Reply-To: <20210614100736.1665072-1-maennich@google.com> (Matthias Maennich's message of "Mon, 14 Jun 2021 11:07:35 +0100")
Matthias Maennich <maennich@google.com> a écrit:
> Refactor the acquisition of symtabs to explicitly provide functionality
> to get the .symtab and .dynsym sections. A later patch will make use of
> that to acquire .symtab while find_symbol_table_section() still provides
> .dynsym as default symbol table.
>
> This also adds a new overload to find_section to acquire the first
> section by type and adjusts find_symbol_table_section() to make use of
> those functions.
>
> * src/abg-elf-helpers.cc(find_section): New overload.
> (find_symtab_section): New function.
> (find_dynsym_section): New function.
> (find_symbol_table_section): Use new find_*_section functions.
> * src/abg-elf-helpers.h(find_section): New overload declaration.
> (find_symtab_section): New function declaration.
> (find_dynsym_section): New function declaration.
>
> Reviewed-by: Giuliano Procida <gprocida@google.com>
> Signed-off-by: Matthias Maennich <maennich@google.com>
Applied to master.
Thanks!
[...]
Cheers,
--
Dodji
prev parent reply other threads:[~2021-07-15 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 10:07 Matthias Maennich
2021-06-14 10:07 ` [PATCH 2/2] symtab-reader: add support for binaries compiled with CFI Matthias Maennich
2021-07-15 16:11 ` Dodji Seketeli
2021-07-15 14:18 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s27fyo9.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).