From: Dodji Seketeli <dodji@redhat.com>
To: libabigail@sourceware.org
Subject: [PATCH, applied] Fix DWARF type DIE canonicalization
Date: Tue, 25 May 2021 11:57:31 +0200 [thread overview]
Message-ID: <878s435e5w.fsf@redhat.com> (raw)
Hello,
While looking at something else, I noticed that the DWARF type DIE
canonicalization code wasn't taking the type of array elements into
account when comparing arrays.
This patch fixes that.
* src/abg-dwarf-reader.cc (compare_dies): When comparing array
type DIEs, take into account the type of the elements of the
arrays.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master.
---
src/abg-dwarf-reader.cc | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc
index dd9d689c..735a4b48 100644
--- a/src/abg-dwarf-reader.cc
+++ b/src/abg-dwarf-reader.cc
@@ -10247,6 +10247,16 @@ compare_dies(const read_context& ctxt,
}
if (found_l_child != found_r_child)
result = false;
+ // Compare the types of the elements of the array.
+ Dwarf_Die ltype_die, rtype_die;
+ bool found_ltype = die_die_attribute(l, DW_AT_type, ltype_die);
+ bool found_rtype = die_die_attribute(r, DW_AT_type, rtype_die);
+ ABG_ASSERT(found_ltype && found_rtype);
+
+ if (!compare_dies(ctxt, <ype_die, &rtype_die,
+ aggregates_being_compared,
+ update_canonical_dies_on_the_fly))
+ return false;
}
break;
--
2.30.0
--
Dodji
reply other threads:[~2021-05-25 9:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s435e5w.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).