From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by sourceware.org (Postfix) with ESMTPS id BDA7B3857C66 for ; Tue, 7 Jul 2020 14:48:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BDA7B3857C66 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 8DEA4FF80F; Tue, 7 Jul 2020 14:48:47 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id E9FC71800AF0; Tue, 7 Jul 2020 16:48:45 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH 1/2] abg-ir.cc: Remove unused re_canonicalize function. Organization: Me, myself and I References: <20200619163924.207852-1-gprocida@google.com> <20200619163924.207852-2-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Workstation 7.8 Beta X-URL: http://www.seketeli.net/~dodji Date: Tue, 07 Jul 2020 16:48:45 +0200 In-Reply-To: <20200619163924.207852-2-gprocida@google.com> (Giuliano Procida's message of "Fri, 19 Jun 2020 17:39:23 +0100") Message-ID: <878sfvs7n6.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2020 14:48:51 -0000 Giuliano Procida a =C3=A9crit: > The function re_canonicalize was added in commit: > > 286cadf8 Bug 24430 - Fold away const for array types > > but later rendered obsolete by commit: > > 5d6af8d5 Delay canonicalization for array and qualified types > > This commit removes the function and its associated declarations. > > * include/abg-fwd.h (re_canonicalize): Remove declaration of > obsolete function. > * include/abg-ir.h (class {decl_base, type_base}): Remove > re_canonicalize friend declarations from these classes. > * src/abg-ir.cc (re_canonicalize): Remove obsolete function. > > Signed-off-by: Giuliano Procida Applied to master, thanks! Cheers, --=20 Dodji