From: Dodji Seketeli <dodji@redhat.com>
To: libabigail@sourceware.org
Subject: [PATCH, applied] reporter-priv: Passing a string parm by reference
Date: Tue, 21 Jun 2022 13:16:41 +0200 [thread overview]
Message-ID: <87a6a6gtba.fsf@redhat.com> (raw)
Hello,
While looking at something else, I noticed the
maybe_report_data_members_replaced_by_anon_dm function was passing a
string parameter by value. Pass this by reference.
* src/abg-reporter-priv.h
(maybe_report_data_members_replaced_by_anon_dm): Pass the string parm by ...
* src/abg-reporter-priv.cc
(maybe_report_data_members_replaced_by_anon_dm): ... reference.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master.
---
src/abg-reporter-priv.cc | 2 +-
src/abg-reporter-priv.h | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/abg-reporter-priv.cc b/src/abg-reporter-priv.cc
index 06145a1b..f41f0ca6 100644
--- a/src/abg-reporter-priv.cc
+++ b/src/abg-reporter-priv.cc
@@ -1387,7 +1387,7 @@ reporter_base::diff_to_be_reported(const diff *d) const
void
maybe_report_data_members_replaced_by_anon_dm(const class_or_union_diff &d,
ostream &out,
- const string indent)
+ const string &indent)
{
const diff_context_sptr& ctxt = d.context();
diff --git a/src/abg-reporter-priv.h b/src/abg-reporter-priv.h
index 42425ef2..d8a9640a 100644
--- a/src/abg-reporter-priv.h
+++ b/src/abg-reporter-priv.h
@@ -238,8 +238,7 @@ maybe_report_interfaces_impacted_by_diff(const diff_sptr &d,
void
maybe_report_data_members_replaced_by_anon_dm(const class_or_union_diff &d,
ostream &out,
- const string indent);
-
+ const string &indent);
void
maybe_report_base_class_reordering(const class_diff &d,
--
2.36.1
--
Dodji
reply other threads:[~2022-06-21 11:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6a6gtba.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).