From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by sourceware.org (Postfix) with ESMTPS id AD0D73814FD1 for ; Tue, 7 Jun 2022 13:17:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD0D73814FD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 35A9E200007; Tue, 7 Jun 2022 13:17:20 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 5F6385800FC; Tue, 7 Jun 2022 15:17:19 +0200 (CEST) From: Dodji Seketeli To: Ben Woodard via Libabigail Subject: Re: [PATCH] Trivial: Add missing space Organization: Me, myself and I References: <20220603124646.315022-1-woodard@redhat.com> X-Operating-System: Fedora 37 X-URL: http://www.seketeli.net/~dodji Date: Tue, 07 Jun 2022 15:17:19 +0200 In-Reply-To: <20220603124646.315022-1-woodard@redhat.com> (Ben Woodard via Libabigail's message of "Fri, 3 Jun 2022 05:46:46 -0700") Message-ID: <87a6aomx40.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 13:17:23 -0000 Ben Woodard via Libabigail a =C3=A9crit: > This is absolutely trivial but I noticed this missing space one day > and fixed it and have been carrying the hunk of patch for months. > > * tools/abicompat.cc - add missing space in expression. Thanks, I have applied this to master. I have just amdended the ChangeLog part of the log to make it comply with the standard. Here is the applied patch. >From bb935f62197532b35bb2d63c4f7cd532a7d91d57 Mon Sep 17 00:00:00 2001 From: Ben Woodard Date: Fri, 3 Jun 2022 05:46:46 -0700 Subject: [PATCH] abicompat: Add missing space This is absolutely trivial but I noticed this missing space one day and fixed it and have been carrying the hunk of patch for months. * tools/abicompat.cc (main): Add missing space in expression. Signed-off-by: Ben Woodard Signed-off-by: Dodji Seketeli --- tools/abicompat.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/abicompat.cc b/tools/abicompat.cc index f4bc384d..913724c7 100644 --- a/tools/abicompat.cc +++ b/tools/abicompat.cc @@ -691,7 +691,7 @@ main(int argc, char* argv[]) suppressions_type& supprs =3D ctxt->suppressions(); bool files_suppressed =3D (file_is_suppressed(opts.app_path, supprs) || file_is_suppressed(opts.lib1_path, supprs) - ||file_is_suppressed(opts.lib2_path, supprs)); + || file_is_suppressed(opts.lib2_path, supprs)); =20 if (files_suppressed) // We don't have to compare anything because a user --=20 2.36.1 --=20 Dodji