From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by sourceware.org (Postfix) with ESMTPS id 2F2A73858D28 for ; Mon, 7 Feb 2022 15:28:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2F2A73858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 40553100007; Mon, 7 Feb 2022 15:28:11 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 19D925802B4; Mon, 7 Feb 2022 16:28:10 +0100 (CET) From: Dodji Seketeli To: David Seifert Cc: libabigail@sourceware.org Subject: Re: [PATCH] Find fts-standalone on musl Organization: Me, myself and I References: <20220207141759.1712914-1-soap@gentoo.org> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Mon, 07 Feb 2022 16:28:10 +0100 In-Reply-To: <20220207141759.1712914-1-soap@gentoo.org> (David Seifert's message of "Mon, 7 Feb 2022 15:17:59 +0100") Message-ID: <87a6f2n1bp.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2022 15:28:15 -0000 David Seifert a =C3=A9crit: > From: Dodji Seketeli > > When using the musl C library fts is optional. So we need to detect > its presence by looking at the fts-standalone pkgconfig module. > > This patch does that. > > This comes from Gentoo bug https://bugs.gentoo.org/831571 > > * configure.ac: Invoke AC_CANONICAL_HOST to compute the host_cpu, > host_vendor, host_os parts of the 'host" variable. Then if the > host_os ends up with "musl" then, check for the fts-standalone > pkgconfig module and record the fts library into > FTS_{LIBS,CFLAGS}. > * src/Makefile.am: Link to $FTS_LIBS and use $FTS_CFLAGS for > compilation. > * tools/Makefile.am: Likewise. > * tools/abisym.cc: Include libgen.h > * tools/kmidiff.cc: Remove useless fts.h header file. > > Signed-off-by: David Seifert > Signed-off-by: Dodji Seketeli Applied to master, thanks! [...] Cheers, --=20 Dodji