From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 54ACF385840E for ; Mon, 22 Nov 2021 20:12:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 54ACF385840E Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AMJTU1R016051 for ; Mon, 22 Nov 2021 20:12:01 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3cg55fvrtv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 22 Nov 2021 20:12:00 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1AMKAkYH055848 for ; Mon, 22 Nov 2021 20:11:58 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2170.outbound.protection.outlook.com [104.47.57.170]) by aserp3030.oracle.com with ESMTP id 3ceq2d5012-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 22 Nov 2021 20:11:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yp0tsomFNoFP86gMjJbSBf8JgYgT3kPg3xRYcd9qqvxTNENRDKkQSOELwjWY4/kT7ck1ar9BEHeOl5j28q7jMHFb9oP2fc8r+04NGpw5oUbIM9qCJjsCmHqpdG1BgRMJOeulvD2fxSEjvGCLOxM2+LrSGzxZhnfgrmL1MJb4DUydVg+CO6rfJXD5AodUYU4a/yIsQLQzjL8I6h/eGHVnso2qv0QTL5pChG1ccIcJvRsnbR53L+KeCtWAqxI+kVwXWnnsFLt9dFxN/VorY4lG9D/lsiubqBvKd1lYpoIORdwCsWirmdKqxlB44Z3tiO3U7cFMU9xzpxlm55iMR+8ioQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6ggi0bLdYRJfFt41WVOoea0l1BFgXF8DSvn7z6z0SHQ=; b=T+ZZ69HIHuDJCY40CIwTe+WZJPZk4opSxThRcIaEjLKChHTpPbpi6F8Fsg+3mgFPLr0XP1d8zNgHSSgWejCaHDo5d3bGPZgf0DBdpxa6SXMT/s109ORuhU/pbswBbqke37ImrL3Bg3LW5RGgTQyDAO/mxgTFcOvL5EjtW3ocr2+h6wzrLUCk9VUNCsEVrbfqXJvUFwaeY+ygaIorNPak/YJdcwvG9SHbdVTsZqtCRXsCFhm5J46vgGg2V0wIp1uwrRqc/IVPTW8GY0XVF5EAjNlV59Rn5ey9lZ3CfnAm660l3PSvnCERVmqQYhTMlM+h1vyjheGi2NxBY1rrvxDYxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by BY5PR10MB4241.namprd10.prod.outlook.com (2603:10b6:a03:208::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Mon, 22 Nov 2021 20:11:56 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::48bf:86b4:32e1:6574]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::48bf:86b4:32e1:6574%4]) with mapi id 15.20.4713.025; Mon, 22 Nov 2021 20:11:56 +0000 From: "Jose E. Marchesi" To: "Guillermo E. Martinez via Libabigail" Subject: Re: [PATCH] ctf-reader: Fix memory leak reported by valgrind References: <20211122185540.1973401-1-guillermo.e.martinez@oracle.com> Date: Mon, 22 Nov 2021 21:11:47 +0100 In-Reply-To: <20211122185540.1973401-1-guillermo.e.martinez@oracle.com> (Guillermo E. Martinez via Libabigail's message of "Mon, 22 Nov 2021 12:55:40 -0600") Message-ID: <87a6hwne64.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0396.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::24) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 Received: from termi.oracle.com (141.143.193.77) by LO2P265CA0396.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.20 via Frontend Transport; Mon, 22 Nov 2021 20:11:55 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fa74b8c9-5f7d-43fd-cf20-08d9adf454e7 X-MS-TrafficTypeDiagnostic: BY5PR10MB4241: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xeHYzTK/gyo0SicTGyKDdjo7CXWb57q/itNCO04+PvVV1mlfiv69OZGnyfnoaDxXVKIX9XSNiEUuhx/vzb0ifBx+NpojIomXni5gtI1Yhk3AEDNh4P+jcVMJ0ClxL4efToOaV1jrn+ml2tEY3kF+4YN53KoRgX+S6yQxewkjph0PqDKkrhU91SOKITNUtTsnZw9U8wTpsaXTuQ3scaO8cJJEN0pzT3PTWJ5xYDSsot3daW+0RpLwsX+GBUb3822FJGVwrt+ELZSXWb8/M9TFDlwaBF2iwJYhlhSvwEE7+kv9Zp07PcBDr0BiBX5XrBF9yPNu0RzzuZR+3eiPA2Xvij5OE21ytZdKc7S+znbmg4rnjVJd2NhPsg3tyVZw+p65MSm13iJZ4oa/XtdJhbWW+zZxNg++M2CC7K1XmdFr0fO4u837msINP+0MXF9GUHMxBBsBuJ5dmR5K/bCFdBcxWmTzEJo4IYPrMvVTcusI8ZZpYvppA4AjH7WjzdRJO0e9aL8/wfxJh1cMUYi+Fwcz7xDrqq5iOW7uTGi+iN1evIr7cgtQiSsPoCvXXisnLGSfGuN7notB2y+idrWQrLq5MKeGXsuMVWCZq8zfu9hoLjSuVNwxLgN+EYwQeXmC/CdJ/lT7mj263A0PBA3n6JatMRfhURN5S+Kpg3Se/mNX8MBpx1i6gw518iQilzrwExBMPkOGo5zHAlPkoQhJAUxHUg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR10MB2888.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(36756003)(2906002)(66476007)(4326008)(5660300002)(6666004)(508600001)(83380400001)(8676002)(316002)(66946007)(8936002)(66556008)(6916009)(7696005)(86362001)(52116002)(38100700002)(38350700002)(107886003)(186003)(6486002)(956004)(26005)(2616005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j1rvp4ZreOLZpS4+7KFbO+zQ6fFbhaM6JIFC71tslCUmZv9u02XJ5F5ibH1B?= =?us-ascii?Q?SkMMwBehDqbY3h8OB1mxMfo/AlN8tTXqned/nYr+CJeqFXmjo0quHiYQ0yiV?= =?us-ascii?Q?nY3DbNIpu4TKi3G+gY0emhdNlcRllhfBUPf5BcNKrI4hPmZIf3jS9/WqhfRt?= =?us-ascii?Q?ymZZS6dm8xkWiJUU6Aqan5bGpnIuWm10qsjmd75DhDnew51meMuL8+uVua1f?= =?us-ascii?Q?CyCSHhhhfVOXDZIbs7e9smq11nj2SLAWGRwm148o7WPeyPpj6W+iJ9+qVYFe?= =?us-ascii?Q?iQVUlxmT3+ILbuDbuzGd5Mzux6kq2qR78Adl+1z5r7hDlomOtw297CVYRN6U?= =?us-ascii?Q?8GYd1Dn7xPw+Rhl4CwfVj8ShenrKCGvgEB1kDUDAZu3CTeB+CUtKpS60AHKQ?= =?us-ascii?Q?xMPtDxXPMlqoPmzsmSwco9LfdqqXMvL0F/1VJ3oHSqDZ7niEiKYpdnH9Aei8?= =?us-ascii?Q?x1wxwoj2dC+XL/AgQVSrG3ZZGRJZaA4+UGvwWJa3d0syagExQJRIQm9YFARN?= =?us-ascii?Q?btuFY1ybB0Cqw6TfGh8bHH69n6nSX+8lhmTl/zBFdo0yGyAa7M3tqqngVBIh?= =?us-ascii?Q?Um5Vl2lOzw9+qgAUwlu4I9MzrErdSgQald6r+68yr9abwiVaeMv4eq5tGewa?= =?us-ascii?Q?lMFQDvZ12d4ojHb2mB6uiAz7w14X8lqrB1efoDsPHZeJeUHq+bOrqWaX1q+p?= =?us-ascii?Q?6UqkmHlq9wbpYeNFaiBeH6CFA/qKTWF3VUVVwtkw1XDylutIv0v/Mc4zmOXF?= =?us-ascii?Q?4j6d899EHp6NhYTXOP1QH6jEW+0JkYPYm/c4Si7iOIGnX9B1T3/baiyAespf?= =?us-ascii?Q?8q1/gP0QAnYxgTX825+lN1i3g7OqWQuQB4SMO9YDuGXbol3Jv+a2+rPhZyMy?= =?us-ascii?Q?OJpeKz0RpXhk0nUx3Wzj1uHCdLcVdNyVSOzuuND3Wzhp882LNPkimhK4sHUZ?= =?us-ascii?Q?2rKfi67JimnPl+n0RNaX9oi372vIS9kpLjEisy2/evRXQinhUFv6WIHJLJZ4?= =?us-ascii?Q?Za8q+5+ASZl35WhAZqqOn3aVXf37xf8t7TnP10keckhJ9NAhnOQijudl8XD4?= =?us-ascii?Q?UBu9r8Zj/UkYWOOFbFSerBaBkS5VUzELiEvvnRroilf8MTwKebJm+DkgBtJK?= =?us-ascii?Q?YXii7UKoHkyLW64FDhSChC+O7WWtW3hXk5fDVpnC7qLa8PIkBqUkS/xfdK2H?= =?us-ascii?Q?iU35AWfYfo/cDRTsekymB2xcxOCF9y7Wzdck4usxTtiD0EemsUyqC9PsC+8+?= =?us-ascii?Q?09wFJMnciQwUFhPjVDgZiFR2w7GlqPrTDLvhKhY29i70I6U13IN2ZsTKX5QF?= =?us-ascii?Q?PKIMK0/51EabEMdSO/Cohm/loWO8aoB3dCXwTnAOKyM52uFQpKAjFfNexBZ8?= =?us-ascii?Q?sTbh575xd9nNjmq+VarAuXPJbcxtPOoDhEmqauDyTDP8ADS2UC/pSYDmpPRm?= =?us-ascii?Q?m0vziRxfdRpUxdHPoDqPIHCvkJfHETbfa4UW6AUFYgPz0l1HP3Zvef2riQBE?= =?us-ascii?Q?Jq15ASGOy/BkU3KLBstFwgbmHGR5KtSad/mfbrCvjxZx20Wt9BVI4BzjMVl5?= =?us-ascii?Q?vvbZgfyWQ3s3sAAFUfeY/ynX1Zt1XVE4aO4f25lrqwhdaoMpbTmrxy+WHxvw?= =?us-ascii?Q?LzBZwsUehkvwBLvzLaRJRw6oPgq+GR0szh7kl5hyFaElqe8mJ4tCOPt3l7Vt?= =?us-ascii?Q?EySIFw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa74b8c9-5f7d-43fd-cf20-08d9adf454e7 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2021 20:11:56.1647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KVlVIFUQySlqT/vc6H8mCJl3SgbcYF23dp/P1jj47+jFEWpSIDlJ+nIMq4OAFP9V5beq2karZPIZ4mrzYjxNMpZAaN4/zGYlUoQ+l4WuG7w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4241 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10176 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111220101 X-Proofpoint-ORIG-GUID: tBKfUJmfzbq8CBSg5rf7jIjf_zdjYRNb X-Proofpoint-GUID: tBKfUJmfzbq8CBSg5rf7jIjf_zdjYRNb X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2021 20:12:05 -0000 > Hello, > > Running unit test with check-valgrind, CTF reader test fails. > > I'll appreciate your comments .. :-) > > Thanks in advanced! > Guillermo LGTM. > > runtestreadctf fails executed by make check-valgrind, a memory leak is > reported: > > at 0x48397B5: malloc (vg_replace_malloc.c:381) > by 0x56E6316: ctf_bufopen_internal (ctf-open.c:1388) > by 0x56E5FD3: ctf_bufopen (ctf-open.c:1297) > by 0x56CD688: ctf_arc_bufopen (ctf-archive.c:444) > by 0x4EB31FD: abigail::ctf_reader::read_corpus(abigail::ctf_reader::read_context*,\ > abigail::elf_reader::status&) (abg-ctf-reader.cc:1111) > by 0x10C6BB: test_task_ctf::perform() (test-read-ctf.cc:236) > by 0x4E8E9AF: abigail::workers::worker::wait_to_execute_a_task\ > (abigail::workers::queue::priv*) (abg-workers.cc:400) > by 0x543BEAD: start_thread (pthread_create.c:463) > by 0x5369A5E: clone (clone.S:95) > > This is happening because `ctf_variable_next' bumps the dictionary > reference counter, so when `ctf_close' is called it doesn't free the > memory allocated by the dict, because `ctf_refcnt' is greater than one. > Therefore `ctf_dict_close' is required. > > * src/abg-ctf-reader.cc (process_ctf_archive): Add > ctf_dict_close > > Signed-off-by: Guillermo E. Martinez > --- > src/abg-ctf-reader.cc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc > index 3e17e049..b31a1b1f 100644 > --- a/src/abg-ctf-reader.cc > +++ b/src/abg-ctf-reader.cc > @@ -941,6 +941,8 @@ process_ctf_archive(read_context *ctxt, corpus_sptr corp) > } > if (ctf_errno(ctf_dict) != ECTF_NEXT_END) > fprintf(stderr, "ERROR from ctf_symbol_next\n"); > + > + ctf_dict_close(ctf_dict); > } > if (ctf_err != ECTF_NEXT_END) > fprintf(stderr, "ERROR from ctf_archive_next\n");