From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by sourceware.org (Postfix) with ESMTPS id C60183848032 for ; Thu, 10 Jun 2021 16:54:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C60183848032 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 7948E1BF20B; Thu, 10 Jun 2021 16:54:17 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 6121E5800FF; Thu, 10 Jun 2021 18:54:16 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH 3/3] abg-reader: create a fresh corpus object per corpus Organization: Me, myself and I References: <20210427112853.1338240-1-gprocida@google.com> <20210427112853.1338240-4-gprocida@google.com> X-Operating-System: Fedora 35 X-URL: http://www.seketeli.net/~dodji Date: Thu, 10 Jun 2021 18:54:16 +0200 In-Reply-To: <20210427112853.1338240-4-gprocida@google.com> (Giuliano Procida's message of "Tue, 27 Apr 2021 12:28:53 +0100") Message-ID: <87a6nx1wzr.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2021 16:54:20 -0000 Giuliano Procida a =C3=A9crit: > Currently the XML reader reuses the same corpus object for all > corpora in a corpus group. This has an unwanted side-effect: any > abi-instr with the same path in different corpora will collide and > parts of the ABI will be lost. > > Creating a new corpus object for every abi-corpus element seems like > the right thing to do. Testing with large ABIs containing many corpora > also shows a modest (~10%) abidiff speed improvement. > > * src/abg-reader.cc (read_corpus_from_input): Always create a > fresh corpus object for each abi-corpus XML element. > > Signed-off-by: Giuliano Procida Applied to master, thanks! [...] Cheers, --=20 Dodji