From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by sourceware.org (Postfix) with ESMTPS id A3D623858D29 for ; Sun, 21 Mar 2021 11:59:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A3D623858D29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org Received: from localhost (unknown [88.120.130.27]) (Authenticated sender: dodji@seketeli.org) by relay10.mail.gandi.net (Postfix) with ESMTPSA id ADABE240012; Sun, 21 Mar 2021 11:59:28 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 7645B581C50; Fri, 19 Mar 2021 17:40:09 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH 1/1] abidw: Treat union members as public by default. Organization: Me, myself and I References: <20210315160418.153481-1-gprocida@google.com> <20210315160418.153481-2-gprocida@google.com> X-Operating-System: Fedora 34 X-URL: http://www.seketeli.net/~dodji Date: Fri, 19 Mar 2021 17:40:09 +0100 In-Reply-To: <20210315160418.153481-2-gprocida@google.com> (Giuliano Procida's message of "Mon, 15 Mar 2021 16:04:18 +0000") Message-ID: <87a6qzw106.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DATE_IN_PAST_24_48, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Mar 2021 11:59:32 -0000 Hello, Giuliano Procida a =C3=A9crit: > This fixes a bug where abidw reports the access of members of C unions > and of C++ unions without any access specifiers as private. > > * src/abg-dwarf-reader.cc (add_or_update_union_type): Replace > "class" with "union" in comments; give union members public > access by default. (finish_member_function_reading): > Give union members public access by default. I edited the ChangeLog a bit to fix the formatting. > (maybe_set_member_type_access_specifier): Give union members > public access by default. > * tests/data/test-annotate/libtest24-drop-fns-2.so.abi: > Refresh. > * tests/data/test-annotate/libtest24-drop-fns.so.abi: > Refresh. > * tests/data/test-annotate/test-anonymous-members-0.o.abi: > Refresh. > * tests/data/test-annotate/test13-pr18894.so.abi: Refresh. > * tests/data/test-annotate/test14-pr18893.so.abi: Refresh. > * tests/data/test-annotate/test15-pr18892.so.abi: Refresh. > * tests/data/test-annotate/test17-pr19027.so.abi: Refresh. > * tests/data/test-annotate/test18-pr19037-libvtkRenderingLIC-6.1.so.abi: > Refresh. > * tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.ab= i: > Refresh. > * tests/data/test-annotate/test20-pr19025-libvtkParallelCore-6.1.so.abi: > Refresh. > * tests/data/test-annotate/test21-pr19092.so.abi: Refresh. > * tests/data/test-diff-dwarf-abixml/PR25409-librte_bus_dpaa.so.20.0.abi: > Refresh. > * tests/data/test-diff-dwarf-abixml/test0-pr19026-libvtkIOSQL-6.1.so.1.a= bi: > Refresh. > * tests/data/test-read-dwarf/PR22015-libboost_iostreams.so.abi: > Refresh. > * tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Refresh. > * tests/data/test-read-dwarf/libtest24-drop-fns-2.so.abi: > Refresh. > * tests/data/test-read-dwarf/libtest24-drop-fns.so.abi: > Refresh. > * tests/data/test-read-dwarf/test-PR26568-1.o.abi: Refresh. > * tests/data/test-read-dwarf/test-PR26568-2.o.abi: Refresh. > * tests/data/test-read-dwarf/test-libandroid.so.abi: Refresh. > * tests/data/test-read-dwarf/test10-pr18818-gcc.so.abi: > Refresh. > * tests/data/test-read-dwarf/test11-pr18828.so.abi: Refresh. > * tests/data/test-read-dwarf/test12-pr18844.so.abi: Refresh. > * tests/data/test-read-dwarf/test13-pr18894.so.abi: Refresh. > * tests/data/test-read-dwarf/test14-pr18893.so.abi: Refresh. > * tests/data/test-read-dwarf/test15-pr18892.so.abi: Refresh. > * tests/data/test-read-dwarf/test16-pr18904.so.abi: Refresh. > * tests/data/test-read-dwarf/test17-pr19027.so.abi: Refresh. > * tests/data/test-read-dwarf/test18-pr19037-libvtkRenderingLIC-6.1.so.ab= i: > Refresh. > * tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.= abi: > Refresh. > * tests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.ab= i: > Refresh. > * tests/data/test-read-dwarf/test21-pr19092.so.abi: Refresh. > * tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi: > Refresh. > * tests/data/test-read-dwarf/test9-pr18818-clang.so.abi: > Refresh. > > Signed-off-by: Giuliano Procida Applied to master, thanks! [...] --=20 Dodji