From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by sourceware.org (Postfix) with ESMTPS id 272193858D28 for ; Tue, 18 Jan 2022 15:59:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 272193858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 550FFFF806; Tue, 18 Jan 2022 15:59:00 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id EE03F581891; Tue, 18 Jan 2022 16:58:59 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com, Mark Wielaard Subject: Re: [PATCH] DWARF reader: use size_t for DWARF expression length cont. Organization: Me, myself and I References: <20220118115645.900414-1-gprocida@google.com> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Tue, 18 Jan 2022 16:58:59 +0100 In-Reply-To: <20220118115645.900414-1-gprocida@google.com> (Giuliano Procida's message of "Tue, 18 Jan 2022 11:56:45 +0000") Message-ID: <87bl09c9x8.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 15:59:05 -0000 Giuliano Procida a =C3=A9crit: > From: Mark Wielaard > > A recent change broke 32-bit builds due to an implicit assumption that > size_t =3D=3D uint64_t. Note that size_t is part of the elfutils > dwarf_getlocation* functions' types. > > The previous fix omitted some instances of uint64_t. This commit > updates further functions to consistently use size_t for DWARF > expression lengths and indexes. > > * src/abg-dwarf-reader.cc (eval_last_constant_dwarf_sub_expr): > Change expr_len argument type to size_t. > (op_pushes_constant_value): Update ops_len and index argument > types to size_t. Update next_index argument type to size_t&. > (op_pushes_non_constant_value): Likewise. > (op_is_arith_logic): Update expr_len and index argument types > to size_t. Update next_index argument type to size_t&. > (op_is_control_flow): Likewise. > > Fixes: 16207c4af7bc ("Bug 28191 - Interpret DWARF 5 addrx locations") > Signed-off-by: Giuliano Procida Applied to master, thanks! [...] Cheers, --=20 Dodji