From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com
Subject: Re: [PATCH 02/11] Improve code comments and whitespace.
Date: Mon, 29 Jun 2020 10:26:56 +0200 [thread overview]
Message-ID: <87bll2uvjj.fsf@seketeli.org> (raw)
In-Reply-To: <20200610115940.26035-3-gprocida@google.com> (Giuliano Procida's message of "Wed, 10 Jun 2020 12:59:31 +0100")
Giuliano Procida <gprocida@google.com> a écrit:
> These are zero impact changes.
>
> * include/abg-fwd.h: Correct doc-comment reference to
> enum_type_decl.
> * src/abg-comp-filter.cc: Fix doc-comment syntax.
> * src/abg-comparison.cc (operator<<): In the diff_category
> overload, fix code indentation.
> * src/abg-default-reporter.cc (report): In the
> class_or_union_diff overload, adjust comment to reflect that
> the code is reporting changes between declaration-only and
> defined types, in either direction.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to master. Thanks!
Cheers,
--
Dodji
next prev parent reply other threads:[~2020-06-29 9:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 11:59 [PATCH 00/11] Add incomplete enum support Giuliano Procida
2020-06-10 11:59 ` [PATCH 01/11] Missing initialisation of source local variable Giuliano Procida
2020-06-10 11:59 ` [PATCH 02/11] Improve code comments and whitespace Giuliano Procida
2020-06-29 8:26 ` Dodji Seketeli [this message]
2020-06-10 11:59 ` [PATCH 03/11] Refactor d.context() as ctxt in report(enum_diff) Giuliano Procida
2020-06-29 8:54 ` Dodji Seketeli
2020-06-10 11:59 ` [PATCH 04/11] Tidy build_enum_type state variables Giuliano Procida
2020-06-29 9:08 ` Dodji Seketeli
2020-06-10 11:59 ` [PATCH 05/11] Rename declaration-definition change category Giuliano Procida
2020-06-29 16:17 ` Dodji Seketeli
2020-06-10 11:59 ` [PATCH 06/11] Support incomplete enums in core and diff code Giuliano Procida
2020-07-06 11:14 ` Dodji Seketeli
[not found] ` <CAGvU0HkuOc74mfL9yLttK4Riwkrj9tmtc3VXxdHAsaCbn2153A@mail.gmail.com>
2020-07-08 9:22 ` Dodji Seketeli
2020-07-08 10:39 ` Giuliano Procida
2020-07-08 15:30 ` Dodji Seketeli
2020-06-10 11:59 ` [PATCH 07/11] Add invariant to enum_type_decl::set_is_declaration_only Giuliano Procida
2020-07-06 11:15 ` Dodji Seketeli
2020-06-10 11:59 ` [PATCH 08/11] Support declaration-only enums in DWARF reader Giuliano Procida
2020-07-06 11:22 ` Dodji Seketeli
2020-06-10 11:59 ` [PATCH 09/11] Support constructing opaque types for enums Giuliano Procida
2020-07-06 11:23 ` Dodji Seketeli
2020-06-10 11:59 ` [PATCH 10/11] Add declaration-only enums to XML reader/writer Giuliano Procida
2020-07-02 13:55 ` Dodji Seketeli
2020-07-02 15:09 ` Giuliano Procida
2020-07-06 11:05 ` Dodji Seketeli
2020-07-06 11:31 ` Dodji Seketeli
2020-07-07 8:31 ` Giuliano Procida
2020-07-07 14:57 ` Dodji Seketeli
2020-06-10 11:59 ` [PATCH 11/11] Add tests for declaration-only enums Giuliano Procida
2020-07-06 11:26 ` Dodji Seketeli
2020-07-01 13:36 ` [PATCH 00/11] Add incomplete enum support Dodji Seketeli
2020-07-01 15:18 ` Giuliano Procida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bll2uvjj.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).