From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by sourceware.org (Postfix) with ESMTPS id 8ED93385E824 for ; Fri, 13 Mar 2020 17:30:14 +0000 (GMT) X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 15BF220008; Fri, 13 Mar 2020 17:30:11 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 27652581890; Fri, 13 Mar 2020 18:30:11 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH 1/5] Fix interaction of --redundant and --leaf-changes-only options. Organization: Me, myself and I References: <20200312063036.29419-1-gprocida@google.com> <20200312063036.29419-2-gprocida@google.com> X-Operating-System: Fedora 33 X-URL: http://www.seketeli.net/~dodji Date: Fri, 13 Mar 2020 18:30:10 +0100 In-Reply-To: <20200312063036.29419-2-gprocida@google.com> (Giuliano Procida's message of "Thu, 12 Mar 2020 06:30:32 +0000") Message-ID: <87blp0w4bh.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2020 17:30:15 -0000 Hello Giuliano, Giuliano Procida a =C3=A9crit: [...] > > * src/abg-comparison.cc (diff_context::show_leaf_changes_only): > Remove "--leaf-changes-only implies --redundant" logic. > * tools/abidiff.cc (display_usage): Mention that > --leaf-changes-only implies --redundant. > (set_diff_context_from_opts): Make --leaf-changes-only imply > --redundant; document this behaviour in a comment. > * tools/abipkgdiff.cc: Ditto. > * tests/data/Makefile.am: Add new test case files. > * tests/data/test-abidiff-exit/test-leaf3-report.txt: Add new > test case, to show --leaf-changes-only implies --redundant. > * tests/data/test-abidiff-exit/test-leaf3-v0.c: Ditto. > * tests/data/test-abidiff-exit/test-leaf3-v0.o: Ditto. > * tests/data/test-abidiff-exit/test-leaf3-v1.c: Ditto. > * tests/data/test-abidiff-exit/test-leaf3-v1.o: Ditto. > * tests/test-abidiff-exit.cc: Run new test case. > * tests/data/test-diff-pkg/libcdio-0.94-1.fc26.x86_64--libcdio-0.94-2.fc= 26.x86_64-report.1.txt: > Update abipkgdiff report with --redundant output. > * tests/data/test-diff-pkg/spice-server-0.12.4-19.el7.x86_64-0.12.8-1.el= 7.x86_64-report-1.txt: > Ditto. > * tests/data/test-diff-pkg/spice-server-0.12.4-19.el7.x86_64-0.12.8-1.el= 7.x86_64-report-2.txt: > Ditto. Looks good to me, applied to master. Thanks! --=20 Dodji