From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122193 invoked by alias); 18 Jan 2019 14:26:15 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Id: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 122050 invoked by uid 89); 18 Jan 2019 14:26:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:964, settled X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: relay12.mail.gandi.net Received: from relay12.mail.gandi.net (HELO relay12.mail.gandi.net) (217.70.178.232) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Jan 2019 14:26:12 +0000 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 8689620001E; Fri, 18 Jan 2019 14:26:08 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 1448F180088E; Fri, 18 Jan 2019 15:26:07 +0100 (CET) From: Dodji Seketeli To: Mark Wielaard Cc: libabigail@sourceware.org Subject: Re: Buildbot failure in Wildebeest Builder on whole buildset Organization: Me, myself and I References: <20190117100851.0E597800729@builder.wildebeest.org> <86tvi7bdeb.fsf@seketeli.org> <91ab2ad3ca3a9c941066caeac01c9d5183397916.camel@klomp.org> X-Operating-System: Red Hat Enterprise Linux Workstation 7.5 X-URL: http://www.seketeli.net/~dodji Date: Tue, 01 Jan 2019 00:00:00 -0000 In-Reply-To: <91ab2ad3ca3a9c941066caeac01c9d5183397916.camel@klomp.org> (Mark Wielaard's message of "Thu, 17 Jan 2019 15:42:54 +0100") Message-ID: <87bm4edou8.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-q1/txt/msg00008.txt.bz2 Mark Wielaard a =C3=A9crit: > aha, I see below that 11 and 14 were also handled there. > Are you sure you need to distinguish these? For example C++03 is just > C++98 with some DRs and no changes in language/abi. Maybe there are abi > differences between the other c++ variants though? Right, I thought about not handling those separately but then settled to just do it, precisely so that I can handle subtle ABI variants related to these in the future. >> @@ -12229,7 +12226,9 @@ dwarf_language_to_tu_language(size_t l) >> return translation_unit::LANG_ObjC; >> case DW_LANG_ObjC_plus_plus: >> return translation_unit::LANG_ObjC_plus_plus; >> +#ifdef DW_LANG_Rust >> case DW_LANG_Rust: >> +#endif >> return translation_unit::LANG_Rust; >> #ifdef DW_LANG_UPC >> case DW_LANG_UPC: > > That endif should probably be added after the return. Oops, you are right. Fixed. Thanks! --=20 Dodji