From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17273 invoked by alias); 15 Dec 2014 08:50:52 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 17262 invoked by uid 89); 15 Dec 2014 08:50:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.98.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx1.redhat.com From: Dodji Seketeli To: Sinny Kumari Cc: libabigail@sourceware.org Subject: Re: [Patch] Adding function added_variables() into class corpus_diff Organization: Red Hat / France References: <642776609.17661594.1418626151614.JavaMail.zimbra@redhat.com> X-Operating-System: Fedora 21 X-URL: http://www.redhat.com Date: Wed, 01 Jan 2014 00:00:00 -0000 In-Reply-To: <642776609.17661594.1418626151614.JavaMail.zimbra@redhat.com> (Sinny Kumari's message of "Mon, 15 Dec 2014 01:49:11 -0500 (EST)") Message-ID: <87bnn5e1p8.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-SW-Source: 2014-q4/txt/msg00006.txt.bz2 Hello, Sinny Kumari writes: > * include/abg-comparison.h (corpus_diff::added_variables): > Declare new member function > * src/abg-comparison.cc (corpus_diff::added_variables): > Define new member function I have applied this to master. I have just slightly edited the title of the patch and I have added an vertical space ... [...] > +/// Getter for the added variables of the diff ... here. This is just to comply with how the doc strings are laid out elsewhere in the source code. > +/// @return the map of added variable. > +const string_var_ptr_map& > +corpus_diff::added_variables() const > +{return priv_->added_vars_;} > + > /// Getter for the variables which signature didn't change but which > /// do have some indirect changes in some sub-types. > /// Thanks for the patch! Cheers, -- Dodji