From: Dodji Seketeli <dodji@redhat.com>
To: libabigail@sourceware.org
Subject: [PATCH, applied] dwarf-reader,abidiff: Fix compilation with --enable-debug-type-canonicalization
Date: Mon, 13 Mar 2023 18:04:45 +0100 [thread overview]
Message-ID: <87cz5coa4y.fsf@redhat.com> (raw)
Hello,
When looking at something else, I configured the package with
--enable-debug-type-canonicalization and surprise, there were some
compilation errors. Fixed thus.
* src/abg-dwarf-reader.cc (reader::initialize): Use env(). rather
than environment->.
* tools/abidiff.cc (options::options): Initialize
do_debug_type_canonicalization() before use_btf.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
src/abg-dwarf-reader.cc | 2 +-
tools/abidiff.cc | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc
index 113dbdcb..037538af 100644
--- a/src/abg-dwarf-reader.cc
+++ b/src/abg-dwarf-reader.cc
@@ -1976,7 +1976,7 @@ public:
options().load_all_types = load_all_types;
#ifdef WITH_DEBUG_TYPE_CANONICALIZATION
debug_die_canonicalization_is_on_ =
- environment->debug_die_canonicalization_is_on();
+ env().debug_die_canonicalization_is_on();
use_canonical_die_comparison_ = true;
#endif
compare_count_ = 0;
diff --git a/tools/abidiff.cc b/tools/abidiff.cc
index 3613a4a3..d2fa5b63 100644
--- a/tools/abidiff.cc
+++ b/tools/abidiff.cc
@@ -175,6 +175,10 @@ struct options
dump_diff_tree(),
show_stats(),
do_log()
+#ifdef WITH_DEBUG_TYPE_CANONICALIZATION
+ ,
+ do_debug_type_canonicalization()
+#endif
#ifdef WITH_CTF
,
use_ctf()
@@ -186,10 +190,6 @@ struct options
#ifdef WITH_DEBUG_SELF_COMPARISON
,
do_debug_self_comparison()
-#endif
-#ifdef WITH_DEBUG_TYPE_CANONICALIZATION
- ,
- do_debug_type_canonicalization()
#endif
{}
--
2.39.2
--
Dodji
reply other threads:[~2023-03-13 17:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz5coa4y.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).