From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=I9DL=5G=seketeli.org=dodji@sourceware.org>
Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222])
	by sourceware.org (Postfix) with ESMTPS id F278A3858289
	for <libabigail@sourceware.org>; Mon,  9 Jan 2023 16:03:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F278A3858289
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org
Received: (Authenticated sender: dodji@seketeli.org)
	by mail.gandi.net (Postfix) with ESMTPSA id 728F54000E;
	Mon,  9 Jan 2023 16:03:16 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org;
	s=gm1; t=1673280197;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=bd76kMrSCDE746hoDryTKBx7YeE8CppqhEtahNZTHzE=;
	b=ShH3MutAXSXH2xfjumZNU64QzUAgx2DiOLc3WY8ItF71FfSThj4UsuPRvEOxHB1XVQIPuV
	2Mz5EU+k0CMW3miglaJWqCtzFdGJzLXT4ZtXMRrHAGhZcSJ0QXB1EZx+DtiFZXBSsudxRx
	sr+YjV6dKxYc6cTCjFqXa2yZ0/UrDKMItB0U3PT7zzLn5RfUBnw1nFMkA+hIdRo9oTP69N
	i5MLn5WUEaD3SfWbcdE6QneNMohF99hlZ5TBXMMOCtCkSuIC2L4LR05MxSWvJ/AnUoSQN4
	YoY3u/0oQTAVYiGxBs5Ruu0A0aoZGIMGBMzZPYppVAdgYgEUHZC8gc374xbJig==
Received: by localhost (Postfix, from userid 1000)
	id AF695581C59; Mon,  9 Jan 2023 17:03:15 +0100 (CET)
From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org,  kernel-team@android.com,
  maennich@google.com,  sidnayyar@google.com,  vvvvvv@google.com
Subject: Re: [PATCH] DWARF reader: avoid C++20 operator!= overload ambiguity
Organization: Me, myself and I
References: <20230109092044.787665-1-gprocida@google.com>
X-Operating-System: Fedora 38
X-URL: http://www.seketeli.net/~dodji
Date: Mon, 09 Jan 2023 17:03:15 +0100
In-Reply-To: <20230109092044.787665-1-gprocida@google.com> (Giuliano Procida's
	message of "Mon, 9 Jan 2023 09:20:44 +0000")
Message-ID: <87cz7nlmpo.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,BELOVED_BODY,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libabigail.sourceware.org>

Hello Giuliano,

First of all, Happy New Year to you and your beloved ones!

Giuliano Procida <gprocida@google.com> a =C3=A9crit:

> C++20 automatically generates overloads for certain comparison
> operators based on others and this can create ambiguity with older
> code. The type expr_result has various operators defined and comparing
> expr_result !=3D int becomes ambiguous.
>
> This change just avoids this comparison by extracting the underlying
> value, rather than making changes to the type itself. There should be
> no change in behaviour and no tests are affected.
>
> 	* (src/abg-dwarf-reader.cc) op_is_control_flow: In the
> 	DW_OP_bra case, when testing the popped value, use the
> 	expr_result's const_value explicitly.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>

Applied to the master branch, thanks!

[...]

Cheers,

--=20
		Dodji