From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dodji@seketeli.org>
Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199])
	by sourceware.org (Postfix) with ESMTPS id 239BC3857C79
	for <libabigail@sourceware.org>; Mon, 29 Aug 2022 11:20:04 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 239BC3857C79
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org
Received: (Authenticated sender: dodji@seketeli.org)
	by mail.gandi.net (Postfix) with ESMTPSA id 81370FF808;
	Mon, 29 Aug 2022 11:19:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org;
	s=gm1; t=1661771999;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=suTtLCS3n8tARxHOfpWt6k/gNm2IZh1T3WXNZIebUZw=;
	b=adCAcQfMY9wRLdMNDkm6+Tt1HbsKdZMX4SkkjYnwumEmxU+WJg0xWyObcRXfTSP3UcsxI2
	ibdFIsr0F7LsWNiEe3F12gA4ak3/OZ/OoTfZxfhcCY1qRPneBD19djDf6dpp9d0EPsPsUo
	VcxBaDb5i6vDAW6S8BEws2SeiS54lUn/iLW5oL7uC5h8MrDtIDQLmwPV/bTv038mpVY6Y1
	zj3Jg7TyuIZV1rqBo6K7cNqE24sRnPMkmDiMql+DTODwOooWf7YbLAB1jz1V15vGf9m6wA
	PdZHRH1sZ1fnxCIBLzaCTeD5wTZ4pHm4BPuHk6khKyJbmUrh6juRZnIFvix/Dg==
Received: by localhost (Postfix, from userid 1000)
	id DF8C25802BD; Mon, 29 Aug 2022 13:19:56 +0200 (CEST)
From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org,  kernel-team@android.com,
  maennich@google.com,  sidnayyar@google.com,  vvvvvv@google.com
Subject: Re: [PATCH 2/3] abidw: remove always true test in
 resolve_declaration_only_classes
Organization: Me, myself and I
References: <20220825114856.3137373-1-gprocida@google.com>
	<20220825114856.3137373-3-gprocida@google.com>
X-Operating-System: Fedora 38
X-URL: http://www.seketeli.net/~dodji
Date: Mon, 29 Aug 2022 13:19:56 +0200
In-Reply-To: <20220825114856.3137373-3-gprocida@google.com> (Giuliano
	Procida's message of "Thu, 25 Aug 2022 12:48:55 +0100")
Message-ID: <87czcjl2jn.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libabigail.sourceware.org>

Giuliano Procida <gprocida@google.com> a =C3=A9crit:

> The code that makes the last attempt to resolve declaration-only types
> was protected by a conditional checking that the number of TUs for a
> given type was more than 1. The previous branch checked for exactly 1.
> However, the entire block is inside a conditional where the number of
> TUs is guaranteed to be greater than 0.
>
> Removing the conditional makes it clear that this branch handles all
> remaining cases.
>
> 	* src/abg-dwarf-reader.cc
> 	(read_context::resolve_declaration_only_classes): Remove
> 	tautological conditional.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>

Applied to master, thanks !

[...]

Cheers,

--=20
		Dodji