From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dodji@seketeli.org>
Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net
 [IPv6:2001:4b98:dc4:8::229])
 by sourceware.org (Postfix) with ESMTPS id F29713838019
 for <libabigail@sourceware.org>; Mon, 16 May 2022 14:34:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F29713838019
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org
Received: (Authenticated sender: dodji@seketeli.org)
 by mail.gandi.net (Postfix) with ESMTPSA id 00480FF80C;
 Mon, 16 May 2022 14:34:27 +0000 (UTC)
Received: by localhost (Postfix, from userid 1000)
 id 5DEAE581C46; Thu, 12 May 2022 12:12:49 +0200 (CEST)
From: Dodji Seketeli <dodji@seketeli.org>
To: Ben Woodard via Libabigail <libabigail@sourceware.org>
Cc: Ben Woodard <woodard@redhat.com>,  vsoch <vsoch@users.noreply.github.com>
Subject: Re: [PATCH] V2 Add Logic to detect file type by extension
Organization: Me, myself and I
References: <20220504195137.1790994-1-woodard@redhat.com>
X-Operating-System: Fedora 36
X-URL: http://www.seketeli.net/~dodji
Date: Thu, 12 May 2022 12:12:48 +0200
In-Reply-To: <20220504195137.1790994-1-woodard@redhat.com> (Ben Woodard via
 Libabigail's message of "Wed, 4 May 2022 12:51:38 -0700")
Message-ID: <87czgjvz33.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 16 May 2022 14:34:31 -0000

Ben Woodard via Libabigail <libabigail@sourceware.org> a =C3=A9crit:

> From: vsoch <vsoch@users.noreply.github.com>
>
> Changes since V1
> Merge in the correct version of the patch not an early diagnostic
> one.
>
> Fedabipkgdiff uses mimetypes to detect what file type it is looking
> at. In some minimal versions of the OS, in particular container
> images, the package that includes all the mimetypes may not be
> installed. This allows fedabipkgdiff to fall back to using the
> extension.
>
>     * tools/fedabipkgdiff - add logic to detect file type by extension
>
> Signed-off-by: vsoch <vsoch@users.noreply.github.com>
> Reviewed-by: Ben Woodard <woodard@redhat.com>


Applied to master, thanks!

Cheers,

--=20
		Dodji