public inbox for
 help / color / mirror / Atom feed
* [PATCH, applied] ir: translation_unit::is_empty should work without environment.
@ 2022-09-05 16:20 Dodji Seketeli
  0 siblings, 0 replies; only message in thread
From: Dodji Seketeli @ 2022-09-05 16:20 UTC (permalink / raw)
  To: libabigail


I noticed that some code failed trying to call
translation_unit::is_empty in the absence of the instance of the
abigail::ir::environment type used to create the IR.

This is because translation_unit::is_empty was trying to create
something.  That's odd.  It shouldn't need to create anything to test
for its emptiness.  Fixed thus.

	* src/ (translation_unit::is_empty): If there is no
	global scope, then we know its empty.  No need to create one.

Signed-off-by: Dodji Seketeli <>
 src/ | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/ b/src/
index 7c8b6640..91c8e99b 100644
--- a/src/
+++ b/src/
@@ -1353,7 +1353,11 @@ translation_unit::get_loc_mgr() const
 /// @return true iff the current translation unit is empty.
 translation_unit::is_empty() const
-{return get_global_scope()->is_empty();}
+  if (!priv_->global_scope_)
+    return true;
+  return get_global_scope()->is_empty();
 /// Getter of the address size in this translation unit.


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-09-05 16:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-05 16:20 [PATCH, applied] ir: translation_unit::is_empty should work without environment Dodji Seketeli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).