public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Dodji Seketeli <dodji@redhat.com>
To: libabigail@sourceware.org
Subject: [PATCH, applied] dwarf-reader: Fix a thinko when building vars
Date: Thu, 14 Jul 2022 16:16:55 +0200	[thread overview]
Message-ID: <87edynaieg.fsf@redhat.com> (raw)

Hello,

While looking at something else, I noticed that we were getting out
early when building the IR for vars.  Fixed thus.

	* src/abg-dwarf-reader.cc (build_ir_node_from_die): Don't get out
	early when building vars.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
 src/abg-dwarf-reader.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc
index 0328079d..02fedbe1 100644
--- a/src/abg-dwarf-reader.cc
+++ b/src/abg-dwarf-reader.cc
@@ -15831,7 +15831,7 @@ build_ir_node_from_die(read_context&	ctxt,
 		      }
 		    ABG_ASSERT(m->get_scope());
 		    ctxt.maybe_add_var_to_exported_decls(m.get());
-		    return m;
+		    result = m;
 		  }
 	      }
 	  }
-- 
2.36.1


-- 
		Dodji


                 reply	other threads:[~2022-07-14 14:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edynaieg.fsf@redhat.com \
    --to=dodji@redhat.com \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).