From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8EC3D3858C52 for ; Thu, 14 Jul 2022 14:17:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8EC3D3858C52 Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-459-MiqIN-B_OMi_TFnwt9EOJQ-1; Thu, 14 Jul 2022 10:16:59 -0400 X-MC-Unique: MiqIN-B_OMi_TFnwt9EOJQ-1 Received: by mail-qk1-f197.google.com with SMTP id o13-20020a05620a2a0d00b006b46c5414b0so1234260qkp.23 for ; Thu, 14 Jul 2022 07:16:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:organization:date:message-id :user-agent:mime-version; bh=89+csIvFlkmTKQtxsAKFHyDPELBKLGo4jqQ067pGdaM=; b=jUoLtdONjdukFlxSOmS9NcDSBvw5lMe7hTpGU95pe5KjTvahq1iP9zQnbVoiwnrh3l TWPIKGQgVHIFdNn9iB//nek+LD5qjHxE7jGJZp2RMs+oWquMk2tOxCl3VOsws4TsTFJB Cza51GzyYXWhaSXssgAwSiAZOvhPjcnC/QFEZPsP1Rw2oejlz9nV75m99pGVMUfgSRr7 5+A2RN/iIBpiyIh1h4y6/hztzLhazW8T6U47sKJGPvjupEdcFVeFfdHXS/XhWxlt+fGw vx0y1zXcQcwgwCUQ3dJuC/7Q08yTqIhvqGwGhuqZikRCM6CzKf1JgHYXZJyR2p9lmggm 00Eg== X-Gm-Message-State: AJIora9DEvTHpsMkLHoLylyeWLp+iQsk2nSGPKvttFfJoNWkeiuTtLxX R7vJYcr5jR79n/tS7k/8bQv8tk4+G6Vk/Dm+IrkT26bZ5aGkINA6dLWjGsGcEyqB/QsUudD/TRo yDhE5sCm8S2t5v5qH4w2FiehuK0DiTCEtxzr1R4kL6NyBx5T4tl/JDkOqdCjlUDqnnthz X-Received: by 2002:ac8:5fd2:0:b0:317:c4b5:b5ac with SMTP id k18-20020ac85fd2000000b00317c4b5b5acmr8303838qta.506.1657808218325; Thu, 14 Jul 2022 07:16:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tDT9QCTx5CK1nm0IafsQbw6ye9aK5aUORtIsnJpNMlfZxE2Emef/eZKhL6k37KHr3ZQpdflg== X-Received: by 2002:ac8:5fd2:0:b0:317:c4b5:b5ac with SMTP id k18-20020ac85fd2000000b00317c4b5b5acmr8303807qta.506.1657808217940; Thu, 14 Jul 2022 07:16:57 -0700 (PDT) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id f5-20020a05620a408500b006afd667535asm1461657qko.83.2022.07.14.07.16.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jul 2022 07:16:57 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 39CFD581C2F; Thu, 14 Jul 2022 16:16:55 +0200 (CEST) From: Dodji Seketeli To: libabigail@sourceware.org Subject: [PATCH, applied] dwarf-reader: Fix a thinko when building vars Organization: Red Hat / France X-Operating-System: Fedora 37 X-URL: http://www.redhat.com Date: Thu, 14 Jul 2022 16:16:55 +0200 Message-ID: <87edynaieg.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2022 14:17:04 -0000 Hello, While looking at something else, I noticed that we were getting out early when building the IR for vars. Fixed thus. * src/abg-dwarf-reader.cc (build_ir_node_from_die): Don't get out early when building vars. Signed-off-by: Dodji Seketeli --- src/abg-dwarf-reader.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc index 0328079d..02fedbe1 100644 --- a/src/abg-dwarf-reader.cc +++ b/src/abg-dwarf-reader.cc @@ -15831,7 +15831,7 @@ build_ir_node_from_die(read_context& ctxt, } ABG_ASSERT(m->get_scope()); ctxt.maybe_add_var_to_exported_decls(m.get()); - return m; + result = m; } } } -- 2.36.1 -- Dodji