From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by sourceware.org (Postfix) with ESMTPS id 723DC3857B82 for ; Mon, 4 Jul 2022 07:20:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 723DC3857B82 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 6400C20013; Mon, 4 Jul 2022 07:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1656919226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t874chb1qdavMPby1yCm6UgZu883aFTbkLjLQG6yicA=; b=lDvO7JtJcBRZ2GhF/3n3adrseksJXNgDBDzKWn3yx32UHA8GokBsiLUoTeQyJliei7f7wY qcKLVJB3ppKwEwhfMbJAtNzsR/NlDAadoNxup6gXOMTjcVJ5cEfOohtrLVqSGJNHRKx5d2 hHR2Ldx8syr3JYIYO3znRUpe3KyYoUkNG86MDo1e5R6PABFYyjOHDsAUGqyO8l+ehEPPjx AAozoKJaxM4r48KPChM0lRfyymzkBOlKzkTmXNZvoiIIouxn90Vf7CwIzl7nZIWWAphISq ze6vcZwhID3jn7zfkp+wmYwIyQMj/rrDFV2rlvd4dLtaYvaD4bURDXFf9TgzTA== Received: by localhost (Postfix, from userid 1000) id 680785800FC; Mon, 4 Jul 2022 09:20:24 +0200 (CEST) From: Dodji Seketeli To: "Guillermo E. Martinez" Cc: "Guillermo E. Martinez via Libabigail" Subject: Re: [PATCH] Add regression tests for abipkgdiff using ctf info Organization: Me, myself and I References: <20220623151642.1904752-1-guillermo.e.martinez@oracle.com> <87ilogdhgp.fsf@seketeli.org> <21542305.EfDdHjke4D@sali> X-Operating-System: Fedora 37 X-URL: http://www.seketeli.net/~dodji Date: Mon, 04 Jul 2022 09:20:24 +0200 In-Reply-To: <21542305.EfDdHjke4D@sali> (Guillermo E. Martinez's message of "Fri, 01 Jul 2022 11:08:52 -0500") Message-ID: <87edz1cpjb.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2022 07:20:29 -0000 Hello Guillermo, "Guillermo E. Martinez" a =C3=A9crit: >> > * tests/test-diff-pkg-ctf.cc: Testsuite for abipkgdiff --ctf. >>=20 >> Why come up with a something else but test-diff-pkg.cc just to test RPMs >> using abipkgdiff --ctf? > Actually that was my first approach, but looking inside of the acts to pe= rform > the abipkgdiff DWARFs test, the steps could be changed in the feature > (new steps in `perform' member function applied to DWARFs not applicable = to CTF), Sorry, I am not sure to understand this. What are the steps that would exist for DWARF that would not in CTF, and that would have to be handled at the testing level, rather than at the level of abipkgdiff/libabigail itself? This is a honest question. I can't think of any such case right now. Do you see any? > so it was my motivation to split the tests. But of course these are my > thoughts, and I will follow you advices because you have much more > experience. So what do you think, worth split the tests for DWARF and CTF? >> I mean, can't we just use test-diff-pkg.cc and fill in entries made of >> instances of struct InOutSpec with InOutSpec::prog_option filled in with >> a string prefixed by " --ctf " ? >>=20 >> Of course, those ctf-related entries would be guarded by #ifdef WITH_CTF >> or the like. >>=20 >>=20 >> Wouldn't that work and be simpler? > For the current implementation, absolutely.=20 Then I'd rather keep the simpler way for now. Unless you think there is an absolute need for the more complicated choice right now, of course. Cheers, --=20 Dodji