From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by sourceware.org (Postfix) with ESMTPS id 62B513858410 for ; Tue, 4 Jan 2022 18:28:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 62B513858410 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 41F4F1C0006; Tue, 4 Jan 2022 18:28:17 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 1C84D581C44; Mon, 3 Jan 2022 17:33:30 +0100 (CET) From: Dodji Seketeli To: Thomas Schwinge Cc: libabigail@sourceware.org, Mark Wielaard Subject: Re: [PATCH] Handle several variants of Python 'imp', 'importlib' modules Organization: Me, myself and I References: <87zgouvskb.fsf@euler.schwinge.homeip.net> <20211221194117.2386192-1-thomas@codesourcery.com> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Mon, 03 Jan 2022 17:33:30 +0100 In-Reply-To: <20211221194117.2386192-1-thomas@codesourcery.com> (Thomas Schwinge's message of "Tue, 21 Dec 2021 20:41:17 +0100") Message-ID: <87ee5oeq3p.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DATE_IN_PAST_24_48, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2022 18:28:21 -0000 Hello Thomas, Happy New Years! Thomas Schwinge a =C3=A9crit: > Fix-up for recent commit f0582fdbf1267f0f34bf3c3b6698b60026410146 > "Replace use of deprecated Python 'imp' module with 'importlib'", and > commit cc1f38ffedb8d456d43fb52c369409037c5ca4a > "Replace Python 'import importlib' with 'import importlib.machinery'", > because... compatibility. > > Once more, I've asked The Internet what to do about that, and this commit= is > the result. But beware: I'm still not much of a Python wizard. > > * tests/mockfedabipkgdiff.in: Handle several variants of Python > 'imp', 'importlib' modules. The patch looks good to me. However, it lacks the 'signed-of-by' mention. [...] Cheers, --=20 Dodji