From: Thomas Schwinge <thomas@codesourcery.com>
To: Dodji Seketeli <dodji@redhat.com>
Cc: <libabigail@sourceware.org>
Subject: Re: [PATCH] CONTRIBUTING: Move "Coding language and style" section
Date: Fri, 17 Dec 2021 23:06:27 +0100 [thread overview]
Message-ID: <87ee6ayjh8.fsf@euler.schwinge.homeip.net> (raw)
In-Reply-To: <87h7b79hwo.fsf@seketeli.org>
Hi Dodji!
On 2021-12-17T19:59:35+0100, Dodji Seketeli <dodji@redhat.com> wrote:
> Thomas Schwinge <thomas@codesourcery.com> a écrit:
>> CONTRIBUTING | 110 +++++++++++++++++++++++++--------------------------
>> 1 file changed, 55 insertions(+), 55 deletions(-)
>>
>> diff --git CONTRIBUTING CONTRIBUTING
>
> I am not sure why, but on patches I use and receive, this line looks
> like:
>
> diff --git a/CONTRIBUTING b/CONTRIBUTING
>
> See the difference of format? This is what I get using git
> format-patch.
>
> I am not sure why yours is different. Any idea?
Yes: local 'git diff' configuration unintentionally leaked into
'git format-patch' as used by 'git send-email'. I've fixed this;
later patches should apply fine as sent.
> In any case, when I do "git am" on your patch, git refuses to apply it.
> I had to edit the patch so that the line looks like:
>
> diff a/CONTRIBUTING b/CONTRIBUTING
>
> at least.
..., or -- as you supposedly have found out a few minutes later ;-) --
apply with "git am -p0". Sorry for that.
Grüße
Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
prev parent reply other threads:[~2021-12-17 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 13:26 [PATCH] Use C++11 for the code base Dodji Seketeli
2020-12-04 17:08 ` Ben Woodard
2021-12-11 17:58 ` [PATCH] CONTRIBUTING: Move "Coding language and style" section Thomas Schwinge
2021-12-17 18:59 ` Dodji Seketeli
2021-12-17 22:06 ` Thomas Schwinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee6ayjh8.fsf@euler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=dodji@redhat.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).