From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by sourceware.org (Postfix) with ESMTPS id 323003858032 for ; Mon, 13 Dec 2021 16:11:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 323003858032 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 7B3E960019; Mon, 13 Dec 2021 16:11:55 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 8BC5558010A; Mon, 13 Dec 2021 17:11:54 +0100 (CET) From: Dodji Seketeli To: "Guillermo E. Martinez via Libabigail" Subject: Re: [PATCH v3] Add regression tests for ctf reading Organization: Me, myself and I References: <0211122213353.2456208-1-guillermo.e.martinez@oracle.com> <20211201030645.3804678-1-guillermo.e.martinez@oracle.com> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Mon, 13 Dec 2021 17:11:54 +0100 In-Reply-To: <20211201030645.3804678-1-guillermo.e.martinez@oracle.com> (Guillermo E. Martinez via Libabigail's message of "Tue, 30 Nov 2021 21:06:45 -0600") Message-ID: <87ee6gqyb9.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, KAM_LOTSOFHASH, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2021 16:12:00 -0000 Hello Guillermo, I ran the tests and found some issues on my system. I have described them below. "Guillermo E. Martinez via Libabigail" a =C3=A9crit: [...] > * tests/data/test-read-ctf/test-enum-many.o.hash.abi: Likewise. [...] > tests/data/test-read-ctf/test-enum-many.c | 10 + [...] > +++ b/tests/test-read-ctf.cc [...] > + { > + "data/test-read-ctf/test-enum-many.o", This file is not present in the patch. So running the test yields: $ ./build/tests/runtestreadctf=20 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 NOT PROCESSED TYPE 18446744073709551615 runtestreadctf: /home/dodji/git/libabigail/patches/tests/test-read-ctf.cc:2= 77: virtual void test_task_ctf::perform(): Assertion `__abg_cond__' failed. Abandon (core dumped) $ The program aborts because "tests/data/test-read-ctf/test-enum-many.o" was not found. You can detect this kind of problems by running 'make distcheck-fast' before submitting the patch. It's super helpful. Also, please be aware that all new files to the tests/data/* directory sub-tree have to be added to the tests/data/Makefile.am so that these files are added to the final distribution tarball. Otherwise, "make distcheck-fast" will fail. [...] diff --git a/tests/data/test-read-dwarf/PR27700/test-PR27700.o b/tests/data= /test-read-dwarf/PR27700/test-PR27700.o deleted file mode 100644 index 3f084d21..00000000 Binary files a/tests/data/test-read-dwarf/PR27700/test-PR27700.o and /dev/n= ull differ diff --git a/tests/data/test-read-dwarf/test-PR26568-1.o b/tests/data/test-= read-dwarf/test-PR26568-1.o [...] > +++ b/tests/test-read-dwarf.cc [...] > { > - "data/test-read-dwarf/test-PR26568-1.o", > + "data/test-read-common/test-PR26568-1.o", This file data/test-read-common/test-PR26568-1.o doesn't exist in the patch. As a result, running runtestreaddwarf yields: $ build/tests/runtestreaddwarf=20 runtestreaddwarf: /home/dodji/git/libabigail/patches/tests/test-read-dwarf.= cc:590: virtual void test_task_dwarf::perform(): Assertion `__abg_cond__' f= ailed. Abandon (core dumped) $ It aborts because at least the file "tests/data/test-read-common/test-PR26568-1.o" is not present. This too can be detected by running "make distcheck-fast". [...] I hope this helps. Thanks. Cheers, --=20 Dodji