From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by sourceware.org (Postfix) with ESMTPS id C0F0C38515E2 for ; Thu, 10 Jun 2021 16:53:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C0F0C38515E2 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id B2E212000A; Thu, 10 Jun 2021 16:53:22 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id A7D855800FF; Thu, 10 Jun 2021 18:53:21 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH v2 2/3] abg-reader: ensure corpus always has a symtab reader Organization: Me, myself and I References: <20210427112853.1338240-1-gprocida@google.com> <20210527085305.1400592-1-gprocida@google.com> <20210527085305.1400592-3-gprocida@google.com> X-Operating-System: Fedora 35 X-URL: http://www.seketeli.net/~dodji Date: Thu, 10 Jun 2021 18:53:21 +0200 In-Reply-To: <20210527085305.1400592-3-gprocida@google.com> (Giuliano Procida's message of "Thu, 27 May 2021 09:53:04 +0100") Message-ID: <87eed91x1a.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2021 16:53:26 -0000 Giuliano Procida a =C3=A9crit: > In the presence of an empty abi-corpus element and with the following > change to always allocate a fresh corpus object, such objects can > sometimes be left without a symtab reader, instead of inheritng one > from the previous corpus. > > The reader is called to obtain sorted lists of symbols during ABI > comparisons. The simplest way to avoid a crash is to maintain the > invariant that a reader object is always present. > > With this change, if there is bad XML preventing symbols from being > read, no error is raised as before, but the logic has been tweaked so > that abi-instr parsing will nevertheless be attempted. > > * src/abg-reader.cc (read_symbol_db_from_input): Fix > documentation for this function. Allow "successful parsing" to > include the case where no symbols were present in the input. > (read_corpus_from_input): Unconditionally set a symtab reader > on the corpus object. Unconditionally parse the abi-instr of a > corpus. > > Signed-off-by: Giuliano Procida Applied to master, thanks! [...] Cheers, --=20 Dodji