From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by sourceware.org (Postfix) with ESMTPS id 906BA3870861 for ; Mon, 27 Apr 2020 11:15:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 906BA3870861 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id BB6E440004; Mon, 27 Apr 2020 11:15:03 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 7F2C5581891; Mon, 27 Apr 2020 13:15:02 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH 1/3] Add tests for declaration-only struct diffs. Organization: Me, myself and I References: <20200422212059.258602-1-gprocida@google.com> X-Operating-System: Fedora 33 X-URL: http://www.seketeli.net/~dodji Date: Mon, 27 Apr 2020 13:15:02 +0200 In-Reply-To: <20200422212059.258602-1-gprocida@google.com> (Giuliano Procida's message of "Wed, 22 Apr 2020 22:20:57 +0100") Message-ID: <87ees9b2o9.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Apr 2020 11:15:07 -0000 Hello Giuliano, Giuliano Procida a =C3=A9crit: > There were no tests exercising this reporting path. The new test is > run with --harmless as these changes are considered harmless. > > * tests/data/Makefile.am: Add new test case files. > * tests/data/test-abidiff-exit/test-decl-struct-report.txt: > New test case generating "declaration-only" output. > * tests/data/test-abidiff-exit/test-decl-struct-v0.c: Ditto. > * tests/data/test-abidiff-exit/test-decl-struct-v0.o: Ditto. > * tests/data/test-abidiff-exit/test-decl-struct-v1.c: Ditto. > * tests/data/test-abidiff-exit/test-decl-struct-v1.o: Ditto. > * tests/test-abidiff-exit.cc: Run new test case. Applied to master, thanks! Cheers, --=20 Dodji