Re: [PATCH v2 0/8] Refactor dwarf-reader: split out ELF helpers

[Dodji Seketeli <dodji@seketeli.org>]

Hello Matthias,

Matthias Maennich <maennich@google.com> a écrit:

> The abg-dwarf-reader.cc has grown into a large compilation unit with a lot of
> responsibilities. This does not only affect the compilation time, but also
> readability of the various implementation details. Hence it makes sense to
> attempt a refactoring of parts of it.
>
> To overcome the above and as a preparation for my future work on the symtab
> reading part, this splits out functionality from the dwarf reader into a new
> set of source files: src/elf-helpers.{h,cc} along with a test that so far only
> serves the purpose of ensuring that the header file can be compiled on its own.
>
> The elf-helpers, sensibly not named elf-utils, contain functionality like
> looking up sections, converting values or deducting information and properties
> in some way from an Elf* handle. They are not exposed to libabigail users as
> they are an implementation detail of libabigail.
>
> This set of changes is only a refactoring with minor cleanups and renames and
> any change to the functionality would be unintentional.

Thank you for doing this!

I have reviewed and applied the patchset to master.

Thanks again!

Cheers,

-- 
		Dodji