From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by sourceware.org (Postfix) with ESMTPS id 65F2F385BF83 for ; Tue, 7 Apr 2020 13:47:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 65F2F385BF83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id BEBCC1C0003; Tue, 7 Apr 2020 13:47:40 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 04365581890; Tue, 7 Apr 2020 15:47:39 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH 1/2] abidiff: More compact references to prior diffs. Organization: Me, myself and I References: <20200403215356.186742-1-gprocida@google.com> X-Operating-System: Fedora 33 X-URL: http://www.seketeli.net/~dodji Date: Tue, 07 Apr 2020 15:47:39 +0200 In-Reply-To: <20200403215356.186742-1-gprocida@google.com> (Giuliano Procida's message of "Fri, 3 Apr 2020 22:53:54 +0100") Message-ID: <87eeszpfus.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2020 13:47:43 -0000 Hello, I like the patch overall, I just have some nits to pick I guess :-) Giuliano Procida a =C3=A9crit: [...] > diff --git a/src/abg-reporter-priv.cc b/src/abg-reporter-priv.cc > index 883c815e..323de503 100644 > --- a/src/abg-reporter-priv.cc > +++ b/src/abg-reporter-priv.cc > @@ -507,11 +507,11 @@ represent(const var_diff_sptr &diff, >=20=20 > if (d->currently_reporting()) > { > - out << " as being reported\n"; > + out << ", as being reported\n"; > } In general, throughout the code we try to only use braces when necessary. I know this change didn't create this situation here (I must have missed it from a previous patch or something) but could you please remove the brace here, for the sake of consistency with the rest of the code. > else if (d->reported_once()) > { > - out << " as reported earlier\n"; > + out << ", as reported earlier\n"; > } Likewise. [...] > @@ -527,13 +527,20 @@ represent(const var_diff_sptr &diff, > if (ctxt->get_reporter()->diff_to_be_reported(d.get())) > { > out << indent > - << "type of '" << pretty_representation << "' changed:\n"; > + << "type of '" << pretty_representation << "' changed"; > if (d->currently_reporting()) > - out << indent << " details are being reported\n"; > + { > + out << ", as being reported\n"; > + } Likewise. > else if (d->reported_once()) > - out << indent << " details were reported earlier\n"; > + { > + out << ", as reported earlier\n"; > + } Likewise. > else > - d->report(out, indent + " "); > + { > + out << ":\n"; > + d->report(out, indent + " "); > + } Likewise. [...] Matthias Maennich a =C3=A9crit: [...] >>+++ b/src/abg-reporter-priv.cc >>@@ -507,11 +507,11 @@ represent(const var_diff_sptr &diff, >> >> if (d->currently_reporting()) >> { >>- out << " as being reported\n"; >>+ out << ", as being reported\n"; > > No need for the braces. Agreed. Thank you Matthias for the review. Cheers, --=20 Dodji