From: Dodji Seketeli <dodji@redhat.com>
To: libabigail@sourceware.org
Subject: [PATCH, applied] ir: Remove redundant virtual member functions
Date: Thu, 12 Oct 2023 13:35:11 +0200 [thread overview]
Message-ID: <87fs2goyz4.fsf@redhat.com> (raw)
Hello,
G++ 13.2.1 complains that virtual member functions
{qualified_type_def,pointer_type_def,class_or_union}::operator!= are
redundant with type_base::operator!=, and rightfully so. This patch
removes those useless virtual member functions.
* include/abg-ir.h
({qualified_type_def,pointer_type_def,class_or_union}::operator!=):
Remove these redundant virtual data members.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to the master branch.
---
include/abg-ir.h | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/include/abg-ir.h b/include/abg-ir.h
index 18e95afd..5a9aed9a 100644
--- a/include/abg-ir.h
+++ b/include/abg-ir.h
@@ -2252,11 +2252,6 @@ public:
virtual bool
operator==(const qualified_type_def&) const;
- virtual bool
- operator!=(const qualified_type_def& other) const {
- return !(*this == other);
- }
-
CV
get_cv_quals() const;
@@ -2359,11 +2354,6 @@ public:
bool
operator==(const pointer_type_def&) const;
- bool
- operator!=(const pointer_type_def& other) const {
- return !(*this == other);
- }
-
const type_base_sptr
get_pointed_to_type() const;
@@ -2428,11 +2418,6 @@ public:
bool
operator==(const reference_type_def&) const;
- bool
- operator!=(const reference_type_def& other) const {
- return !(*this == other);
- }
-
type_base_sptr
get_pointed_to_type() const;
@@ -4114,11 +4099,6 @@ public:
virtual bool
operator==(const class_or_union&) const;
- virtual bool
- operator !=(const class_or_union& other) const {
- return !(*this == other);
- }
-
virtual bool
traverse(ir_node_visitor& v);
--
2.39.3
--
Dodji
reply other threads:[~2023-10-12 11:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs2goyz4.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).