Re: [PATCH] abidiff: improve whitespace generation in symbol diff report

[Dodji Seketeli <dodji@seketeli.org>]

Matthias Maennich <maennich@google.com> a écrit:

> maybe_report_diff_for_symbol() has a few issues:
>
> 1. The responsibility for newline emission is somewhat unclear and
>    indeed it would emit spurious blank lines before most of the
>    sub-diffs it reports.
>
> 2. Different sub-diff text and terminal commas are emitted according to
>    whether or not there had been a previous sub-diff - making the output
>    harder to grep and post-process.
>
> 3. The function also returns a bool but that return value is never used.
>
> Hence, change the function to return void, the function stanzas to
> always emit newline-terminated lines and ensure the wording and
> punctuation of each sub-diff do not vary. This also tweaks (shortens)
> the wording used for CRC diffs.
>
> 	* src/abg-reporter-priv.cc (maybe_report_diff_for_symbol):
> 	Make return void. Simplify and fix new-line emission. Remove
> 	comma emission. Tweak CRC wording.
> 	* src/abg-reporter-priv.h (maybe_report_diff_for_symbol):
> 	Return void.
> 	* tests/data/test-abidiff-exit/test-crc-report.txt: Shorten CRC
> 	wording.
> 	* tests/data/test-abidiff/test-crc-report.txt: Likewise.
> 	* tests/data/test-diff-filter/test-PR27569-report-0.txt:
> 	Likewise.
>
> Reviewed-by: Giuliano Procida <gprocida@google.com>
> Signed-off-by: Matthias Maennich <maennich@google.com>

Applied to master, thanks!

[...]

Cheers,

-- 
		Dodji