From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::227]) by sourceware.org (Postfix) with ESMTPS id 2EEA2385801F for ; Tue, 18 Jan 2022 12:03:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2EEA2385801F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 5541C20003; Tue, 18 Jan 2022 12:03:48 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id E7F4D5802B4; Tue, 18 Jan 2022 13:03:47 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com, mark@klomp.org Subject: Re: [PATCH] DWARF reader: use size_t for DWARF expression length Organization: Me, myself and I References: <20220117145115.659444-1-gprocida@google.com> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Tue, 18 Jan 2022 13:03:47 +0100 In-Reply-To: <20220117145115.659444-1-gprocida@google.com> (Giuliano Procida's message of "Mon, 17 Jan 2022 14:51:15 +0000") Message-ID: <87fsplckt8.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 12:03:53 -0000 Giuliano Procida a =C3=A9crit: > A recent change broke 32-bit builds due to an implicit assumption that > size_t =3D=3D uint64_t. This appears in the elfutils dwarf_getlocation* > functions' types. > > This commit updates callers and other functions to use size_t > consistently for such expression lengths and indexes. > > * src/abg-dwarf-reader.cc (die_location_expr): Change expr_len > argument type to size_t*. > (op_manipulates_stack): Change expr_len and index argument > types to size_t; change next_index argument type to size_t&. > (eval_last_constant_dwarf_sub_expr): Change expr_len argument > and local variables index and next_index types to size_t. > (die_member_offset): Change local variable expr_len type to > size_t. > (die_location_address): Likewise. > (die_virtual_function_index): Likewise. > > Fixes: 16207c4af7bc ("Bug 28191 - Interpret DWARF 5 addrx locations") > Signed-off-by: Giuliano Procida Applied to master, thanks! [...] Cheers, --=20 Dodji