Re: [PATCH] abg-ir.cc: Add types_have_similar_structure tests.

[Dodji Seketeli <dodji@seketeli.org>]

Matthias Maennich <maennich@google.com> a écrit:

> On Thu, Mar 26, 2020 at 05:53:50PM +0000, Giuliano Procida wrote:
>>This is a follow-up to a recent commit. This patch adds more tests, as
>>suggested by a reviewer.
>>
>>	* src/abg-ir.cc (types_have_similar_structure): Update TODO
>>	regarding structure of arrays - multidimensional arrays are
>>	the issue.
>>	* tests/data/test-abidiff-exit/test-leaf-peeling-report.txt:
>>	Updated following changes.
>>	* tests/data/test-abidiff-exit/test-leaf-peeling-v0.cc: Add
>>	more cases (see below).
>>	* tests/data/test-abidiff-exit/test-leaf-peeling-v0.o:
>>	Updated.
>>	* tests/data/test-abidiff-exit/test-leaf-peeling-v1.cc: Add
>>	comment about a potential change to local-change semantics;
>>	add test cases to demonstrate that * and & and * and *** are
>>	structurally different; add a TODO regarding multidimensional
>>	arrays where changes are sometimes missed in leaf mode.
>>	* tests/data/test-abidiff-exit/test-leaf-peeling-v1.o
>>
>>Signed-off-by: Giuliano Procida <gprocida@google.com>
>
> Thanks for adding those additional test cases!
> Reviewed-by: Matthias Maennich <maennich@google.com>

Applied to master.

Thanks!

-- 
		Dodji