From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com
Subject: Re: [PATCH 2/2 v2] [abidiff] Add more leaf change reporting.
Date: Fri, 13 Mar 2020 18:02:18 +0100 [thread overview]
Message-ID: <87ftecw5lx.fsf@seketeli.org> (raw)
In-Reply-To: <20200313153429.142808-1-gprocida@google.com> (Giuliano Procida's message of "Fri, 13 Mar 2020 15:34:29 +0000")
Giuliano Procida <gprocida@google.com> a écrit:
> The leaf-changes-only reporting path does not report on all the same
> kinds of differences as the default reporting path does, such as
> reporting about changes to variables, even though they can be
> considered leaf changs.
>
> - The addition or removal of any symbol affects the ABI and is
> clearly a leaf change.
> - A change to a variable's declaration may be local rather than
> caused by a type change elsewhere.
>
> This patch adds these missing pieces and reorders some of the existing
> leaf reporting, bringing the default and leaf corpus_diff functions
> closer to the point where they can be trivially merged or refactored.
>
> This patch also corrects an error in reporting the total number of
> leaf changes.
>
> * src/abg-comparison.cc (emit_diff_stats): Exclude non-leaf
> changes to variables from the reported total of leaf changes.
> * src/abg-default-reporter.cc (report): In the corpus_diff
> override, move some code and comments for clarity.
> * src/abg-leaf-reporter.cc (report): In the corpus_diff
> override, additionally report removed/added/changed variables
> and removed/added symbols absent from debug info.
> * tests/data/Makefile.am: Add new test case files.
> * tests/data/test-abidiff-exit/test-leaf0-report.txt: Update
> to include reporting of variable diff (change of type).
> * tests/data/test-abidiff-exit/test-leaf1-report.txt: New test
> case with added/removed variables/functions and changed
> variables (both local and non-local type changes).
> * tests/data/test-abidiff-exit/test-leaf1-v0.cc: Ditto.
> * tests/data/test-abidiff-exit/test-leaf1-v0.o: Ditto.
> * tests/data/test-abidiff-exit/test-leaf1-v1.cc: Ditto.
> * tests/data/test-abidiff-exit/test-leaf1-v1.o: Ditto.
> * tests/test-abidiff-exit.cc: Run new test case. Supply
> --redundant otherwise the test isn't meaningful.
This looks OK to me. I have just updated the manual of the abi{pkg}diff
tools to say that --leaf-changes-only implies --redudant, just as you
did in the help string of these tools.
The patch was applied to master.
Thanks!
--
Dodji
next prev parent reply other threads:[~2020-03-13 17:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 10:35 [PATCH 1/2] [abidiff] Fix spurious new lines after diff sections Giuliano Procida
2020-03-11 10:35 ` [PATCH 2/2] [abidiff] Add more leaf change reporting Giuliano Procida
2020-03-13 10:28 ` Dodji Seketeli
2020-03-13 14:00 ` Giuliano Procida
2020-03-13 15:34 ` [PATCH 2/2 v2] " Giuliano Procida
2020-03-13 17:02 ` Dodji Seketeli [this message]
2020-03-13 17:22 ` Giuliano Procida
2020-03-13 17:26 ` Giuliano Procida
2020-03-12 13:03 ` [PATCH 1/2] [abidiff] Fix spurious new lines after diff sections Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftecw5lx.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).