From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by sourceware.org (Postfix) with ESMTPS id B77D73857C7C for ; Mon, 29 Aug 2022 11:19:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B77D73857C7C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 13F76240003; Mon, 29 Aug 2022 11:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1661771975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mNjenWWOgwbi2vbQrK/rFi8XhnqFaqsB6YgRSEtkdpA=; b=d6Yk6hWwKyMXHGcbEVN2AvKRI7Hemi/da1nWf93c8nM82R+xN6pC5Tu/L1zdvqAv8JqIyq 5LCzTPVoOIlRbl5rv5awxuuaPTQT59twOHzany2IE9GL6mehDs2BA/w28nh/pAyrz/7ihQ BfUYyfzbpjhDFjW4tQeuU/Vo/W/F88qDNSCDxTMhLoepuWl2xg2mYYe/1WvLq8FD8z5lnK xDDaLPEtVeB6v1GpU8/xufa5YbzzCuJTREbOfc08LNdcSHSSyPx/8tSAfr/41E4m7IQoOZ w2BlABIplarUS2T3GQ/OIWkJpm7YsBtpC0e7aVqIXU3AfXn1dilFVInU4vJwVA== Received: by localhost (Postfix, from userid 1000) id 5DC905802BD; Mon, 29 Aug 2022 13:19:33 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com, sidnayyar@google.com, vvvvvv@google.com Subject: Re: [PATCH 1/3] abidw: fix --stats output for resolved classes and enums Organization: Me, myself and I References: <20220825114856.3137373-1-gprocida@google.com> <20220825114856.3137373-2-gprocida@google.com> X-Operating-System: Fedora 38 X-URL: http://www.seketeli.net/~dodji Date: Mon, 29 Aug 2022 13:19:33 +0200 In-Reply-To: <20220825114856.3137373-2-gprocida@google.com> (Giuliano Procida's message of "Thu, 25 Aug 2022 12:48:54 +0100") Message-ID: <87h71vl2ka.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Giuliano Procida a =C3=A9crit: > The code to print out the remaining declaration-only types > unintentionally omitted the first such type. This change fixes the > logic and uses a single test to decide whether or not to print the > stats header line. > > * src/abg-dwarf-reader.cc > (read_context::resolve_declaration_only_classes): Fix > conditional logic so that showing stats includes the first > unresolved type. > (read_context::resolve_declaration_only_enums): Likewise. > > Signed-off-by: Giuliano Procida Applied to master, thanks! Cheers, [...] --=20 Dodji