From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5FC0A3858412 for ; Fri, 17 Dec 2021 19:19:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5FC0A3858412 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-581-VipRqsTBPxqd_VlF-RGgog-1; Fri, 17 Dec 2021 14:19:18 -0500 X-MC-Unique: VipRqsTBPxqd_VlF-RGgog-1 Received: by mail-wm1-f72.google.com with SMTP id l6-20020a05600c4f0600b0033321934a39so1456240wmq.9 for ; Fri, 17 Dec 2021 11:19:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=I4f8CnkBcgQ99SLmrhI69jAGaGl0jb1M+avyDrYHGoI=; b=ob/iNFwdillhHcVw3tp+zS76LVAM5lL4F5zxdpr2jpCz2j8oBOn84T4mG5TNd0BdPA drym62H/gIWPSt5QPEc+0WhNxdqnl2gWfkL+SqyZLumyul9Pf1ojrUvcO+QM6xNOdetT 4pj4iQ3+Jvi1A7zl4OwyO7VaB0+wReAKksk3hB/ApEn1Kc0/8ZV7UTecTzO6SLL8EhW6 vCie21eKj6TOQiZFAcIvq/gvP4zmqGHesbExJnpRItIlXIH8LK5syjBgomDFNPvmpiH3 +TxUcrY1oNw3p5YVPGNC7SyzBrLAUDuFSQUkD3ZI/vPDrDertcBC0vE8rXp1yX+VYa9g p0Wg== X-Gm-Message-State: AOAM531NWsZGFY11Hul46XGJnuJI8Pjd79qcW9Mnk6MJr4SfZN/SMV9g AlHdMJickZ4d+6J6GWctnDnd7M0Cm/3TKym4/twPM+SlfDIGiV1VxoUKJ8jJPFdP1sa2BGz/XU7 vtyL+7gP0Pvy4bKMD2eTy X-Received: by 2002:a05:600c:c1:: with SMTP id u1mr10696383wmm.163.1639768757619; Fri, 17 Dec 2021 11:19:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJyAO3hJu4xgXiLeMHSGytpBQGOoYYabU81k1D8WoyLeVCHfdEMGlkQdfpRoix++iSWJpTFe6Q== X-Received: by 2002:a05:600c:c1:: with SMTP id u1mr10696367wmm.163.1639768757444; Fri, 17 Dec 2021 11:19:17 -0800 (PST) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id d2sm7944574wra.61.2021.12.17.11.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Dec 2021 11:19:16 -0800 (PST) Received: by localhost (Postfix, from userid 1000) id 6C6BA581C2E; Fri, 17 Dec 2021 19:59:35 +0100 (CET) From: Dodji Seketeli To: Thomas Schwinge Cc: libabigail@sourceware.org, Dodji Seketeli Subject: Re: [PATCH] CONTRIBUTING: Move "Coding language and style" section Organization: Me, myself and I References: <86ft4nowan.fsf@redhat.com> <20211211175822.950836-1-thomas@codesourcery.com> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Fri, 17 Dec 2021 19:59:35 +0100 In-Reply-To: <20211211175822.950836-1-thomas@codesourcery.com> (Thomas Schwinge's message of "Sat, 11 Dec 2021 18:58:22 +0100") Message-ID: <87h7b79hwo.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 19:19:22 -0000 Hello, Thomas Schwinge a =C3=A9crit: [...] > CONTRIBUTING | 110 +++++++++++++++++++++++++-------------------------- > 1 file changed, 55 insertions(+), 55 deletions(-) > > diff --git CONTRIBUTING CONTRIBUTING I am not sure why, but on patches I use and receive, this line looks like: diff --git a/CONTRIBUTING b/CONTRIBUTING See the difference of format? This is what I get using git format-patch. I am not sure why yours is different. Any idea? I am using git 2.33. In any case, when I do "git am" on your patch, git refuses to apply it. I had to edit the patch so that the line looks like: diff a/CONTRIBUTING b/CONTRIBUTING at least. [...] > This section got added in commit 4f8c9b170d80b920d13e8f291b347df74db34307 > "Use C++11 for the code base", but unfortunately got placed in the middle > of the "Regression tests" section. Move it after that one. > > =09* CONTRIBUTING: Move "Coding language and style" section. > > Signed-off-by: Thomas Schwinge Applied to master. Thanks! [...] Cheers, --=20 =09=09Dodji