public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Dodji Seketeli <dodji@redhat.com>
To: dodji@redhat.com
Cc: libabigail@sourceware.org
Subject: [PATCH 00/16] Fixing various issues found while working on PR30309
Date: Thu, 07 Sep 2023 15:32:46 +0200	[thread overview]
Message-ID: <87il8mglc1.fsf@redhat.com> (raw)

Hello,

While working on the problem report 30309 at
https://sourceware.org/bugzilla/show_bug.cgi?id=30309, I found several
smaller related issues that could be addressed independently from the
reported problem itself.  As the initial issue still needs more care,
I think it's worthwhile to merge the following patches into the main
line the source code.

Please note that the original issue is being handled in the branch
"canonicalize-types-in-order" at
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/users/dodji/canonicalize-types-in-order.

I am thus merging the patches that follows this message into the main
branches, from the "canonicalize-types-in-order" branch.

Dodji Seketeli (16):
  reader: fix indentation
  tools-utils: Fix indentation
  dwarf-reader,ir: Make logging a property of the middle end
  dwarf-reader: Fix some logging
  abipkgdiff: Initialize libxml2 to use it in a multi-thread context
  tools-utils: Avoid endless loop
  {dwarf,elf}reader: Don't consider no symbol table as an error
  abipkgdiff: Avoid comparing binaries that are outside of the package
  ir: Add missing ABG_RETURN in the comparison engine
  ir: Add fn types to type lookup maps
  ir: Fix forgetting canonicalizing some function types
  ir: Avoid forgetting potential seemingly duplicated member functions
  ir: Really avoid canonicalizing decl-only classes
  ir: Use non qualified typedef name for type canonicalization
  ir: Fix qualification as non-confirmed propagated canonical types
  dwarf-reader: Do not re-use typedefs in a scope

 include/abg-fwd.h                             |     8 +-
 include/abg-ir.h                              |    11 +-
 include/abg-tools-utils.h                     |     1 +
 src/abg-dwarf-reader.cc                       |    38 +-
 src/abg-elf-reader.cc                         |     8 +-
 src/abg-ir-priv.h                             |    21 +-
 src/abg-ir.cc                                 |   328 +-
 src/abg-reader.cc                             |    76 +-
 src/abg-tools-utils.cc                        |    40 +-
 tests/data/Makefile.am                        |     2 +
 .../test-abidiff/test-PR18791-report0.txt     |    13 -
 tests/data/test-annotate/libtest23.so.abi     |   453 +-
 .../test-annotate/libtest24-drop-fns-2.so.abi |   598 +-
 .../test-annotate/libtest24-drop-fns.so.abi   |   598 +-
 .../data/test-annotate/test15-pr18892.so.abi  | 14179 ++--
 .../data/test-annotate/test17-pr19027.so.abi  |  2162 +-
 ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi |  8862 +--
 ...19-pr19023-libtcmalloc_and_profiler.so.abi |  7403 +-
 ...st20-pr19025-libvtkParallelCore-6.1.so.abi | 10938 +--
 .../data/test-annotate/test21-pr19092.so.abi  |    88 +-
 .../test42-PR21296-clanggcc-report0.txt       |    14 +-
 .../test31-pr18535-libstdc++-report-0.txt     |    31 +-
 .../test31-pr18535-libstdc++-report-1.txt     |    31 +-
 .../data/test-diff-filter/test41-report-0.txt |    30 +-
 .../symlink-dir-test1-report1.txt             |     0
 .../symlink-dir-test1-report1.txt             |     0
 .../PR22015-libboost_iostreams.so.abi         |  2291 +-
 .../test-read-dwarf/PR22122-libftdc.so.abi    | 14659 ++--
 .../data/test-read-dwarf/PR25007-sdhci.ko.abi |  8778 +--
 tests/data/test-read-dwarf/libtest23.so.abi   |   447 +-
 .../libtest24-drop-fns-2.so.abi               |   586 +-
 .../test-read-dwarf/libtest24-drop-fns.so.abi |   586 +-
 .../test-read-dwarf/test-libaaudio.so.abi     |     8 +-
 .../test-read-dwarf/test-libandroid.so.abi    | 12052 ++--
 tests/data/test-read-dwarf/test0.hash.abi     |     4 +-
 tests/data/test-read-dwarf/test1.hash.abi     |    10 +-
 .../test-read-dwarf/test10-pr18818-gcc.so.abi |  3136 +-
 .../test-read-dwarf/test11-pr18828.so.abi     | 11668 ++--
 .../test-read-dwarf/test12-pr18844.so.abi     | 24630 ++++---
 .../test-read-dwarf/test15-pr18892.so.abi     | 13995 ++--
 .../test-read-dwarf/test16-pr18904.so.abi     | 16831 ++---
 .../test-read-dwarf/test17-pr19027.so.abi     |  2132 +-
 ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi |  8768 +--
 ...19-pr19023-libtcmalloc_and_profiler.so.abi |  7127 +-
 ...st20-pr19025-libvtkParallelCore-6.1.so.abi | 10671 +--
 .../test-read-dwarf/test21-pr19092.so.abi     |    82 +-
 .../test22-pr19097-libstdc++.so.6.0.17.so.abi | 57411 ++++++++--------
 .../test9-pr18818-clang.so.abi                |  3545 +-
 .../test28-without-std-fns-ref.xml            |   350 +-
 .../test28-without-std-vars-ref.xml           |   348 +-
 tests/test-diff-pkg.cc                        |    32 +-
 tools/abipkgdiff.cc                           |    27 +-
 52 files changed, 121298 insertions(+), 124809 deletions(-)
 create mode 100644 tests/data/test-diff-pkg-ctf/symlink-dir-test1-report1.txt
 create mode 100644 tests/data/test-diff-pkg/symlink-dir-test1-report1.txt

-- 
2.39.3

-- 
		Dodji


             reply	other threads:[~2023-09-07 13:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07 13:32 Dodji Seketeli [this message]
2023-09-07 13:34 ` [PATCH 01/16] reader: fix indentation Dodji Seketeli
2023-09-07 13:35 ` [PATCH 02/16] tools-utils: Fix indentation Dodji Seketeli
2023-09-07 13:38 ` [PATCH 03/16] dwarf-reader,ir: Make logging a property of the middle end Dodji Seketeli
2023-09-07 13:39 ` [PATCH 04/16] dwarf-reader: Fix some logging Dodji Seketeli
2023-09-07 13:39 ` [PATCH 05/16] abipkgdiff: Initialize libxml2 to use it in a multi-thread context Dodji Seketeli
2023-09-07 13:40 ` [PATCH 06/16] tools-utils: Avoid endless loop Dodji Seketeli
2023-09-07 13:41 ` [PATCH 07/16] {dwarf,elf}reader: Don't consider no symbol table as an error Dodji Seketeli
2023-09-07 13:41 ` [PATCH 08/16] abipkgdiff: Avoid comparing binaries that are outside of the package Dodji Seketeli
2023-09-07 13:42 ` [PATCH 09/16] ir: Add missing ABG_RETURN in the comparison engine Dodji Seketeli
2023-09-07 14:02 ` [PATCH 10/16] ir: Add fn types to type lookup maps Dodji Seketeli
2023-09-07 14:03 ` [PATCH 11/16] ir: Fix forgetting canonicalizing some function types Dodji Seketeli
2023-09-07 14:05 ` [PATCH 12/16] ir: Avoid forgetting potential seemingly duplicated member functions Dodji Seketeli
2023-09-07 14:07 ` [PATCH 13/16] ir: Really avoid canonicalizing decl-only classes Dodji Seketeli
2023-09-07 14:08 ` [PATCH 14/16] ir: Use non qualified typedef name for type canonicalization Dodji Seketeli
2023-09-07 14:09 ` [PATCH 15/16] ir: Fix qualification as non-confirmed propagated canonical types Dodji Seketeli
2023-09-07 14:10 ` [PATCH 16/16] dwarf-reader: Do not re-use typedefs in a scope Dodji Seketeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87il8mglc1.fsf@redhat.com \
    --to=dodji@redhat.com \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).