From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by sourceware.org (Postfix) with ESMTPS id 6AAF5384D9AA for ; Fri, 18 Nov 2022 14:11:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6AAF5384D9AA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 0B5951BF210; Fri, 18 Nov 2022 14:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1668780688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OQ9eL5+xbX383mCMpzx2ZqCadi9U47VqkMNZHbNCTIQ=; b=DAd9iYHWPhfVg0CFLOM1L6K/snBE4a0XD7CyO8put5qxdp71kS/zVmwNkGFOyzr14LTWFT lIS4agJ8fSF//DPzQsi6/D/o07XBpSUUhrF+gBlbcA6QQUUJqGq0nawhdbAj/ac8x7lZNF q3CxdS5z39g9p3Vm45fAtcDgZp7YvHzKUyf+lrVQ0iEVEY/6B/lVrCX44nBS0LRBtPnGWo Ps7vqOw0ytdJ3dfJOb8y8AMS7fj3OOPVsJGGgIHG424nuT9mZeU68f6oqlngLdBSWrrS2k 0KXxXRg6t+WNIYQaiHhBXG21Cccw28PaGKT66SAZWJ/Nc/ID2n9gjJdFXpJRnQ== Received: by localhost (Postfix, from userid 1000) id 69D43581C59; Fri, 18 Nov 2022 15:11:26 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com, sidnayyar@google.com, vvvvvv@google.com Subject: Re: [PATCH] symtab: add support for CRC values from __kcrctab Organization: Me, myself and I References: <20221118090907.4013918-1-gprocida@google.com> X-Operating-System: Fedora 38 X-URL: http://www.seketeli.net/~dodji Date: Fri, 18 Nov 2022 15:11:26 +0100 In-Reply-To: <20221118090907.4013918-1-gprocida@google.com> (Giuliano Procida's message of "Fri, 18 Nov 2022 09:09:07 +0000") Message-ID: <87iljcmjxt.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Giuliano Procida a =C3=A9crit: > From: Aleksei Vetrov > > New kernels changed the format of storing CRC values from absolute > symbol value to the address in __kcrctab or __kcrctab_gpl section. > This change adds support for CRC values described in this format. > > * src/abg-elf-helpers.h (get_crc_for_symbol): Defined new > helper function to extract CRC from ELF symbol. > * src/abg-elf-helpers.cc (get_crc_for_symbol): Implemented this > function with support of old and new CRC values format. > * src/abg-symtab-reader.cc (symtab::load_): Used the new > function when building CRC values map. > > Change-Id: I7de5c737d5caaef0c5b7b2ea0d448368889a16be > Signed-off-by: Aleksei Vetrov Applied to master, thanks! [...] Cheers, --=20 Dodji