From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by sourceware.org (Postfix) with ESMTPS id 2E59E3858D28 for ; Fri, 1 Jul 2022 14:40:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2E59E3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 9B6A0FF80A; Fri, 1 Jul 2022 14:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1656686423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fihTiWN3Hzi422I8j/JGcOGf1g4VZn+Bc+Lu7NlzHX0=; b=fQvONr0pNllF89vG+1e5EUxNkT3epDZkxZW7mY41seezpDQwPrpDiXO7rlTmOL1NxmVJT8 Q1KPZQYhebK1bTFlG1WFe0TxxymMgmbhr1Aqul8pCNaceaVmYKM2umGeKxxblMfMCULvQT Ggmbmwv93qyA4Jq648ecabiC5QOG7ZSB5Z8gWGU8SWQTgayp6USnOtj47bqIc889X1M1+o VnWCsmOmFr8hu7dramuemZsjhw51J4C/bvrXZXtGwEfOdNel6Uj/+7sHDYXEz9cEsgIaaj Bc+aUloVKIcLZEOEuY3OBKpL0tCfEG3kHj8ZH/hrcGcKd3vOwLgy856eF/j5fA== Received: by localhost (Postfix, from userid 1000) id DABB6581C4A; Fri, 1 Jul 2022 16:40:22 +0200 (CEST) From: Dodji Seketeli To: "Guillermo E. Martinez via Libabigail" Subject: Re: [PATCH] Add regression tests for abipkgdiff using ctf info Organization: Me, myself and I References: <20220623151642.1904752-1-guillermo.e.martinez@oracle.com> X-Operating-System: Fedora 37 X-URL: http://www.seketeli.net/~dodji Date: Fri, 01 Jul 2022 16:40:22 +0200 In-Reply-To: <20220623151642.1904752-1-guillermo.e.martinez@oracle.com> (Guillermo E. Martinez via Libabigail's message of "Thu, 23 Jun 2022 10:16:42 -0500") Message-ID: <87ilogdhgp.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2022 14:40:26 -0000 Hello Guillermo, "Guillermo E. Martinez via Libabigail" a =C3=A9crit: Thank you for working on this. It's appreciated. I have a question however. [...] > This patch implements the regression tests for abipkgdiff tool to help > process packages win ctf debug information. Since the code shares > lots of functionalities already used with abipkgdiff in comparing > packages with dwarf info, a library was built. I am wondering ... [...] > * tests/test-diff-pkg-ctf.cc: Testsuite for abipkgdiff --ctf. Why come up with a something else but test-diff-pkg.cc just to test RPMs using abipkgdiff --ctf? I mean, can't we just use test-diff-pkg.cc and fill in entries made of instances of struct InOutSpec with InOutSpec::prog_option filled in with a string prefixed by " --ctf " ? Of course, those ctf-related entries would be guarded by #ifdef WITH_CTF or the like. Wouldn't that work and be simpler? [...] Cheers, --=20 Dodji