From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by sourceware.org (Postfix) with ESMTPS id B6E5B3896C3D for ; Thu, 10 Jun 2021 16:52:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B6E5B3896C3D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id B7ED61BF207; Thu, 10 Jun 2021 16:52:34 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 74E215800FF; Thu, 10 Jun 2021 18:52:33 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH v2 1/3] abg-dwarf-reader: create new corpus unconditionally Organization: Me, myself and I References: <20210427112853.1338240-1-gprocida@google.com> <20210527085305.1400592-1-gprocida@google.com> <20210527085305.1400592-2-gprocida@google.com> X-Operating-System: Fedora 35 X-URL: http://www.seketeli.net/~dodji Date: Thu, 10 Jun 2021 18:52:33 +0200 In-Reply-To: <20210527085305.1400592-2-gprocida@google.com> (Giuliano Procida's message of "Thu, 27 May 2021 09:53:03 +0100") Message-ID: <87im2l1x2m.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2021 16:52:40 -0000 Giuliano Procida a =C3=A9crit: > The DWARF reader appears to create a new corpus object only if one is > not already present. However, the only case where there can be > multiple corpora is when build_corpus_group_from_kernel_dist_under is > called and this function clears down the reader context, including the > current corpus, between reading ELF objects. > > So it's clearer to just create a fresh corpus object unconditionally > in the DWARF reader. > > * src/abg-dwarf-reader.cc (read_debug_info_into_corpus): > Create new corpus object unconditionally. > > Signed-off-by: Giuliano Procida Applied to master. Thanks! [...] Cheers, --=20 Dodji