From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by sourceware.org (Postfix) with ESMTPS id 809493857C65 for ; Mon, 27 Jul 2020 13:28:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 809493857C65 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 2B5381BF207; Mon, 27 Jul 2020 13:28:02 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id AFCB2180090F; Mon, 27 Jul 2020 15:28:01 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH 2/3] Remove unused is_reference_or_pointer_diff. Organization: Me, myself and I References: <20200709131429.1366074-1-gprocida@google.com> <20200709131429.1366074-3-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Workstation 7.8 Beta X-URL: http://www.seketeli.net/~dodji Date: Mon, 27 Jul 2020 15:28:01 +0200 In-Reply-To: <20200709131429.1366074-3-gprocida@google.com> (Giuliano Procida's message of "Thu, 9 Jul 2020 14:14:28 +0100") Message-ID: <87ime9hyu6.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2020 13:28:07 -0000 Giuliano Procida a =C3=A9crit: > The function is_reference_or_pointer_diff was added in commit > > 85929105 Fix redundancy marking for change of types used directly > > and was updated to peel typedefs as a first step in > > ef9d20c9 Fix redundancy detection through fn ptr and typedef paths > > which, however, also made it obsolete. > > This commit removes the function's declaration and definition. > There are no functional changes. > > * include/abg-comparison.h (is_reference_or_pointer_diff): > Drop function declaration. > * src/abg-comparison.cc (is_reference_or_pointer_diff): Drop > function definition. > > Signed-off-by: Giuliano Procida Applied to master, thanks! [...] Cheers, --=20 Dodji