From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by sourceware.org (Postfix) with ESMTPS id 5B973386F82E for ; Wed, 22 Apr 2020 09:56:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5B973386F82E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 6602E20006; Wed, 22 Apr 2020 09:56:06 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 9993C581891; Wed, 22 Apr 2020 11:56:05 +0200 (CEST) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, gprocida@google.com, kernel-team@android.com Subject: Re: [PATCH v2 8/8] abg-elf-helpers: migrate maybe_adjust_et_rel_sym_addr_to_abs_addr Organization: Me, myself and I References: <20200420110846.218792-1-maennich@google.com> <20200421063551.222511-1-maennich@google.com> <20200421063551.222511-9-maennich@google.com> X-Operating-System: Fedora 33 X-URL: http://www.seketeli.net/~dodji Date: Wed, 22 Apr 2020 11:56:05 +0200 In-Reply-To: <20200421063551.222511-9-maennich@google.com> (Matthias Maennich's message of "Tue, 21 Apr 2020 08:35:51 +0200") Message-ID: <87imhrdetm.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2020 09:56:09 -0000 Matthias Maennich a =C3=A9crit: [...] > * src/abg-dwarf-reader.cc(maybe_adjust_et_rel_sym_addr_to_abs_addr): Adding a space here -------------^ Likewise or the relevant lines below. > Move out functions (drop the wrapped overload completely). > * src/abg-elf-helpers.cc(maybe_adjust_et_rel_sym_addr_to_abs_addr): > New function. > * src/abg-elf-helpers.h(maybe_adjust_et_rel_sym_addr_to_abs_addr): > New function declaration. Applying to master with that change. Thanks! Cheers, --=20 Dodji