Re: [Patch] Adding new methods in corpus_diff class

Re: [Patch] Adding new methods in corpus_diff class

[Dodji Seketeli]

Sinny Kumari <sinny@redhat.com> a écrit:

[...]

> Functions added_unrefed_function_symbols() and
> added_unrefed_variable_symbols() are required in order to access
> added functions and variables obtained while calculating abi diff
> between libraries with no debug information available
>
> 	* include/abg-comparison.h
> 	(corpus_diff::added_unrefed_function_symbols):
> 	Declare new member function
> 	(corpus_diff::added_unrefed_variable_symbols):
> 	Declare new member function
> 	* src/abg-comparison.cc
> 	(corpus_diff::added_unrefed_function_symbols):
> 	Define new member function
> 	(corpus_diff::added_unrefed_variable_symbols):
> 	Define new member function
>
> Signed-off-by: Sinny Kumari <skumari@redhat.com>

[...]

I have applied and pushed this patch to master.  Thanks!

Cheers,

-- 
		Dodji

[Patch] Adding new methods in corpus_diff class

[Sinny Kumari]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

Hi,

Public methods are needed to access added functions and variables obtained outside libabigail
while calculating abi diff between libraries with no debug information available.

This patch (available in attachment) adds new public methods in corpus_diff class- 
added_unrefed_function_symbols() and added_unrefed_variable_symbols() to fix same.

Thanks
-- 
     
     Sinny Kumari
(sinny at redhat dot com)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-new-methods-in-corpus_diff-class.patch --]
[-- Type: text/x-patch; name=0001-Add-new-methods-in-corpus_diff-class.patch, Size: 2800 bytes --]

From 201cbcf668e01790faf8c51238cdbf857577a9c8 Mon Sep 17 00:00:00 2001
From: Sinny Kumari <skumari@redhat.com>
Date: Wed, 17 Dec 2014 17:26:26 +0530
Subject: [PATCH 1/1] Add new methods in corpus_diff class

Functions added_unrefed_function_symbols() and
added_unrefed_variable_symbols() are required in order to access
added functions and variables obtained while calculating abi diff
between libraries with no debug information available

	* include/abg-comparison.h
	(corpus_diff::added_unrefed_function_symbols):
	Declare new member function
	(corpus_diff::added_unrefed_variable_symbols):
	Declare new member function
	* src/abg-comparison.cc
	(corpus_diff::added_unrefed_function_symbols):
	Define new member function
	(corpus_diff::added_unrefed_variable_symbols):
	Define new member function

Signed-off-by: Sinny Kumari <skumari@redhat.com>
---
 include/abg-comparison.h |  6 ++++++
 src/abg-comparison.cc    | 18 ++++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/include/abg-comparison.h b/include/abg-comparison.h
index ec89cc6..6ed33ca 100644
--- a/include/abg-comparison.h
+++ b/include/abg-comparison.h
@@ -2057,8 +2057,14 @@ public:
   deleted_unrefed_function_symbols() const;
 
   const string_elf_symbol_map&
+  added_unrefed_function_symbols() const;
+
+  const string_elf_symbol_map&
   deleted_unrefed_variable_symbols() const;
 
+  const string_elf_symbol_map&
+  added_unrefed_variable_symbols() const;
+
   const diff_context_sptr
   context() const;
 
diff --git a/src/abg-comparison.cc b/src/abg-comparison.cc
index fd7e3dd..665d12c 100644
--- a/src/abg-comparison.cc
+++ b/src/abg-comparison.cc
@@ -10225,6 +10225,15 @@ const string_elf_symbol_map&
 corpus_diff::deleted_unrefed_function_symbols() const
 {return priv_->deleted_unrefed_fn_syms_;}
 
+/// Getter for function symbols not referenced by any debug info and
+/// that got added.
+///
+/// @return a map of elf function symbols not referenced by any debug
+/// info and that got added.
+const string_elf_symbol_map&
+corpus_diff::added_unrefed_function_symbols() const
+{return priv_->added_unrefed_fn_syms_;}
+
 /// Getter for variable symbols not referenced by any debug info and
 /// that got deleted.
 ///
@@ -10234,6 +10243,15 @@ const string_elf_symbol_map&
 corpus_diff::deleted_unrefed_variable_symbols() const
 {return priv_->deleted_unrefed_var_syms_;}
 
+/// Getter for variable symbols not referenced by any debug info and
+/// that got added.
+///
+/// @return a map of elf variable symbols not referenced by any debug
+/// info and that got added.
+const string_elf_symbol_map&
+corpus_diff::added_unrefed_variable_symbols() const
+{return priv_->added_unrefed_var_syms_;}
+
 /// Getter of the diff context of this diff
 ///
 /// @return the diff context for this diff.
-- 
2.1.0