From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=3gh1=BB=seketeli.org=dodji@sourceware.org>
Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193])
	by sourceware.org (Postfix) with ESMTPS id AB8EC3858C54
	for <libabigail@sourceware.org>; Fri, 12 May 2023 08:39:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB8EC3858C54
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org
Received: (Authenticated sender: dodji@seketeli.org)
	by mail.gandi.net (Postfix) with ESMTPSA id 2B05A240008;
	Fri, 12 May 2023 08:39:16 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org;
	s=gm1; t=1683880756;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xd6vZscR0ix85esGuIiAV6lnmPF/LKRgHDyfEH88wLI=;
	b=drzHM/x4+p9rpeDZkBEL0CLGeGNA60ZE4SuBrpf92Qs2KE/R+lX7av0Sg4Br4sGTz7rO2I
	vsqnvHbOSZEMh1l2e+HSSraMWj/XCyRYMZbz2JtjaPm8GT0/IYhNL+B3u2jJ0+N3Ai/rms
	00Dlke4Tzxe5lSszpBYaBNtLF6W5EC4oQqFL6PftCy7NHiSTKYapKUYKjibZ7e2c1JmBKj
	5L6BE6T2WZDxKMlDNG6mIlvY9YlD11lZny2dNxGoXQAzXBhcaTEKByn374G1cpDsa8zOTo
	WBgZEoRecO0dIuDIr/jzxcxFeMiCJmsT71ULM9ie2dpgggZxx2Z8QJn6aTrN0g==
Received: by localhost (Postfix, from userid 1000)
	id 35C33581C90; Thu, 11 May 2023 18:24:37 +0200 (CEST)
From: Dodji Seketeli <dodji@seketeli.org>
To: "Dmitry V. Levin" <ldv@strace.io>
Cc: libabigail@sourceware.org
Subject: Re: [PATCH] elf-helpers: make sure config.h is included first
Organization: Me, myself and I
References: <20230501202007.GA30201@altlinux.org>
X-Operating-System: Fedora 39
X-URL: http://www.seketeli.net/~dodji
Date: Thu, 11 May 2023 18:24:37 +0200
In-Reply-To: <20230501202007.GA30201@altlinux.org> (Dmitry V. Levin's message
	of "Mon, 1 May 2023 23:20:07 +0300")
Message-ID: <87jzxedeey.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DATE_IN_PAST_12_24,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libabigail.sourceware.org>

Hello Dmitry,

"Dmitry V. Levin" <ldv@strace.io> a =C3=A9crit:

> Before this change, verify-elf used to complain on x86 and armv7:
> verify-elf: ERROR: ./usr/lib/libabigail.so.2.0.0: uses non-LFS functions:=
 open
>
> Include config.h in abg-elf-helpers.cc before other headers so that
> AC_SYS_LARGEFILE applies to this file.  This fully enables LFS
> in those of 32-bit systems that do not enable it by default.
>
> 	* src/abg-elf-helpers.cc: Include "config.h" first.
>
> Fixes: 7bd69830520f ("Make Front Ends first class citizens")
> Signed-off-by: Dmitry V. Levin <ldv@strace.io>

This looks good to me so I have applied to patch to the master branch
upstream.

Thanks a lot for your contribution.

[...]

Cheers,

--=20
		Dodji