From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by sourceware.org (Postfix) with ESMTPS id 959EA3851C1B for ; Tue, 16 Mar 2021 11:39:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 959EA3851C1B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 88.120.130.27 Received: from localhost (unknown [88.120.130.27]) (Authenticated sender: dodji@seketeli.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 9874F6000A; Tue, 16 Mar 2021 11:39:09 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id BACE258000E; Tue, 16 Mar 2021 12:39:08 +0100 (CET) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, gprocida@google.com, kernel-team@android.com Subject: Re: [PATCH 13/20] symtab_reader: add support for ppc64 ELFv1 binaries Organization: Me, myself and I References: <20200619214305.562-1-maennich@google.com> <20210127125853.886677-1-maennich@google.com> <20210127125853.886677-14-maennich@google.com> X-Operating-System: Fedora 34 X-URL: http://www.seketeli.net/~dodji Date: Tue, 16 Mar 2021 12:39:08 +0100 In-Reply-To: <20210127125853.886677-14-maennich@google.com> (Matthias Maennich's message of "Wed, 27 Jan 2021 12:58:46 +0000") Message-ID: <87k0q7xr8j.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 11:39:14 -0000 Hello, Matthias Maennich a =C3=A9crit: [...] > diff --git a/src/abg-symtab-reader.cc b/src/abg-symtab-reader.cc > index 4576be2a0b42..7318fdfce52e 100644 > --- a/src/abg-symtab-reader.cc > +++ b/src/abg-symtab-reader.cc > @@ -100,9 +100,15 @@ const elf_symbol_sptr& > symtab::lookup_symbol(GElf_Addr symbol_addr) const > { > static const elf_symbol_sptr empty_result; > - const auto it =3D addr_symbol_map_.find(symbol_addr); > - if (it !=3D addr_symbol_map_.end()) > - return it->second; > + const auto addr_it =3D addr_symbol_map_.find(symbol_addr); > + if (addr_it !=3D addr_symbol_map_.end()) > + return addr_it->second; > + else > + { Please add a comment here saying that this case is about the function entry addresses that are relevant for PPC ELFv1. > + const auto entry_it =3D entry_addr_symbol_map_.find(symbol_addr); > + if (entry_it !=3D entry_addr_symbol_map_.end()) > + return entry_it->second; > + } > return empty_result; > } [...] > +void Please add a comment for this function so that the API doc is complete. > +symtab::update_function_entry_address_symbol_map( > + Elf* elf_handle, Please move this first function parameter to the same line as the opening parenthesis and align the other parameters accordingly. > + GElf_Sym* native_symbol, > + const elf_symbol_sptr& symbol_sptr) > +{ > + [...] > Reviewed-by: Giuliano Procida > Signed-off-by: Matthias Maennich OK to apply to master with the above changes once the prerequisite patches have been applied. Thanks! [...] Cheers, --=20 Dodji