From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: Matthias Maennich <maennich@google.com>,
Giuliano Procida via Libabigail <libabigail@sourceware.org>,
kernel-team@android.com
Subject: Re: [PATCH] abipkgdiff: Address operator precedence warning
Date: Tue, 26 Jan 2021 17:22:32 +0100 [thread overview]
Message-ID: <87k0rzhdmf.fsf@seketeli.org> (raw)
In-Reply-To: <CAGvU0Hms6G4bKZ=TC0hVRdFmEkZtpdD13Y=ZZ-g8JniVgE4ZbA@mail.gmail.com> (Giuliano Procida's message of "Tue, 26 Jan 2021 11:54:12 +0000")
Giuliano Procida <gprocida@google.com> a écrit:
> On Tue, 26 Jan 2021 at 09:57, Matthias Maennich <maennich@google.com> wrote:
>>
>> When compiling with clang, it (rightfully) complains about an operator
>> precedence issue:
>>
>> abipkgdiff.cc:1646:7: error: operator '?:' has lower precedence than '<<'; '<<' will be evaluated first [-Wparentheses]
>> ? string("Comparison against self SUCCEEDED\n")
>> ^
>>
>> Fix that by properly placing the parentheses. Also, drop the superfluous
>> string conversion.
>>
>> * tools/abipkgdiff.cc (compare_to_self): address clang warning.
>>
>> Signed-off-by: Matthias Maennich <maennich@google.com>
> Reviewed-by: Giuliano Procida <gprocida@google.com>
>
> Looks good to me.
Applied to master, thanks!
Cheers,
--
Dodji
prev parent reply other threads:[~2021-01-26 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 9:56 Matthias Maennich
2021-01-26 11:54 ` Giuliano Procida
2021-01-26 16:22 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0rzhdmf.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).